2021-11-24 02:36:35

by Yang Li

Subject: [PATCH -next 1/2] tsnep: fix resource_size.cocci warnings

Use resource_size function on resource object
instead of explicit computation.

Clean up coccicheck warning:
./drivers/net/ethernet/engleder/tsnep_main.c:1155:21-24: ERROR: Missing
resource_size with io

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/engleder/tsnep_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index 6a7feb2..c48e8ea 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -1152,7 +1152,7 @@ static int tsnep_probe(struct platform_device *pdev)
adapter->addr = devm_ioremap_resource(&pdev->dev, io);
if (IS_ERR(adapter->addr))
return PTR_ERR(adapter->addr);
- adapter->size = io->end - io->start + 1;
+ adapter->size = resource_size(io);
adapter->irq = platform_get_irq(pdev, 0);
netdev->mem_start = io->start;
netdev->mem_end = io->end;
--
1.8.3.1

2021-11-24 02:36:38

by Yang Li

Subject: [PATCH -next 2/2] tsnep: fix platform_no_drv_owner.cocci warning

Remove .owner field if calls are used which set it automatically

Eliminate the following coccicheck warning:
./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set
.owner here. The core will do it.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/engleder/tsnep_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index c48e8ea..3d0408e 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -1260,7 +1260,6 @@ static int tsnep_remove(struct platform_device *pdev)
static struct platform_driver tsnep_driver = {
.driver = {
.name = TSNEP,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(tsnep_of_match),
},
.probe = tsnep_probe,
--
1.8.3.1

2021-11-24 20:28:49

by Gerhard Engleder

Subject: Re: [PATCH -next 1/2] tsnep: fix resource_size.cocci warnings

> adapter->addr = devm_ioremap_resource(&pdev->dev, io);
> if (IS_ERR(adapter->addr))
> return PTR_ERR(adapter->addr);
> - adapter->size = io->end - io->start + 1;
> + adapter->size = resource_size(io);

In fact adapter->size can be removed completely, because it is used nowhere.
I will submit a patch.

Gerhard

2021-11-24 20:32:42

by Gerhard Engleder

Subject: Re: [PATCH -next 2/2] tsnep: fix platform_no_drv_owner.cocci warning

>
> Remove .owner field if calls are used which set it automatically
>
> Eliminate the following coccicheck warning:
> ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set
> .owner here. The core will do it.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/net/ethernet/engleder/tsnep_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
> index c48e8ea..3d0408e 100644
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -1260,7 +1260,6 @@ static int tsnep_remove(struct platform_device *pdev)
> static struct platform_driver tsnep_driver = {
> .driver = {
> .name = TSNEP,
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(tsnep_of_match),
> },
> .probe = tsnep_probe,
> --
> 1.8.3.1
>

Reviewed-by: Gerhard Engleder <[email protected]>

2021-11-25 02:13:42

by Jakub Kicinski

Subject: Re: [PATCH -next 2/2] tsnep: fix platform_no_drv_owner.cocci warning

On Wed, 24 Nov 2021 21:32:27 +0100 Gerhard Engleder wrote:
> >
> > Remove .owner field if calls are used which set it automatically
> >
> > Eliminate the following coccicheck warning:
> > ./drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set
> > .owner here. The core will do it.
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Gerhard Engleder <[email protected]>

Applied this one and took Gerhard's patch for the resource size thing.
Thanks!