Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
Fannal C3004 is a 480x800 MIPI DSI Panel which requires
DCS initialization sequences with certain delays between certain
commands.
Signed-off-by: Paulo Pavacic <[email protected]>
---
v3 changelog:
- renamed yml file
- refactored yml file to describe fannal,c3004
- added matrix URI to MAINTAINERS
v2 changelog:
- revised driver title, now describes purpose
- revised description, now describes hw
- revised maintainers, now has only 1 mail
- removed diacritics from commit/commit author
- properties/compatible is now enum
- compatible using only lowercase
- revised dts example
- modified MAINTAINERS in this commit (instead of driver commit)
- dt_bindings_check checked yml
- checkpatch warning fixed
---
.../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
MAINTAINERS | 6 ++
3 files changed, 83 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
new file mode 100644
index 000000000000..a86b5ce02aa2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fannal C3004 MIPI-DSI
+
+maintainers:
+ - Paulo Pavacic <[email protected]>
+
+description: |
+ Fannal C3004 is a 480x800 panel which requires DSI DCS
+ initialization sequences.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: fannal,c3004
+
+ reg: true
+ reset-gpios: true
+
+ vdd-supply:
+ description: power supply voltage
+ vddio-supply:
+ description: power supply voltage for IO
+
+ width-mm:
+ description: physical panel width [mm]
+ height-mm:
+ description: physical panel height [mm]
+
+ panel-timing: true
+
+required:
+ - compatible
+ - reg
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ panel@0 {
+ compatible = "fannal,c3004";
+ reg = <0>;
+ pinctrl-0 = <&pinctrl_mipi_dsi_rst>;
+ pinctrl-names = "default";
+ reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+ vdd-supply = <®1>;
+ vddio-supply = <®2>;
+ width-mm = <93>;
+ height-mm = <56>;
+ panel-timing {
+ clock-frequency = <27000000>;
+ hactive = <480>;
+ vactive = <800>;
+ hfront-porch = <30>;
+ hback-porch = <30>;
+ hsync-len = <8>;
+ vback-porch = <30>;
+ vfront-porch = <30>;
+ vsync-len = <8>;
+ };
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 82d39ab0231b..f962750f630a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -462,6 +462,8 @@ patternProperties:
description: Facebook
"^fairphone,.*":
description: Fairphone B.V.
+ "^fannal,.*":
+ description: Fannal Electronics Co., Ltd
"^faraday,.*":
description: Faraday Technology Corporation
"^fastrax,.*":
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c22c828ab46..62374c8424b9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c
+DRM DRIVER FOR FANNAL C3004373132019A
+M: Paulo Pavacic <[email protected]>
+S: Maintained
+C: matrix:r/mipi-dsi-bringup:matrix.org
+F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml
+
DRM DRIVER FOR FARADAY TVE200 TV ENCODER
M: Linus Walleij <[email protected]>
S: Maintained
--
2.40.1
Hey Paulo,
On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote:
>
> Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> DCS initialization sequences with certain delays between certain
> commands.
>
> Signed-off-by: Paulo Pavacic <[email protected]>
> ---
> v3 changelog:
> - renamed yml file
> - refactored yml file to describe fannal,c3004
> - added matrix URI to MAINTAINERS
> v2 changelog:
> - revised driver title, now describes purpose
> - revised description, now describes hw
> - revised maintainers, now has only 1 mail
> - removed diacritics from commit/commit author
> - properties/compatible is now enum
> - compatible using only lowercase
> - revised dts example
> - modified MAINTAINERS in this commit (instead of driver commit)
> - dt_bindings_check checked yml
> - checkpatch warning fixed
> ---
> .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 6 ++
> 3 files changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> new file mode 100644
> index 000000000000..a86b5ce02aa2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fannal C3004 MIPI-DSI
> +
> +maintainers:
> + - Paulo Pavacic <[email protected]>
> +
> +description: |
> + Fannal C3004 is a 480x800 panel which requires DSI DCS
> + initialization sequences.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: fannal,c3004
> +
> + reg: true
Are there no restrictions on the number of reg entries?
> + reset-gpios: true
Can you put a blank line between properties please?
> +
> + vdd-supply:
> + description: power supply voltage
> + vddio-supply:
> + description: power supply voltage for IO
> +
> + width-mm:
> + description: physical panel width [mm]
> + height-mm:
> + description: physical panel height [mm]
Here and for the supplies too.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 82d39ab0231b..f962750f630a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -462,6 +462,8 @@ patternProperties:
> description: Facebook
> "^fairphone,.*":
> description: Fairphone B.V.
> + "^fannal,.*":
> + description: Fannal Electronics Co., Ltd
This needs to be split into a commit of its own.
Thanks,
Conor.
> "^faraday,.*":
> description: Faraday Technology Corporation
> "^fastrax,.*":
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c22c828ab46..62374c8424b9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
> F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
> F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c
>
> +DRM DRIVER FOR FANNAL C3004373132019A
> +M: Paulo Pavacic <[email protected]>
> +S: Maintained
> +C: matrix:r/mipi-dsi-bringup:matrix.org
> +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml
> +
> DRM DRIVER FOR FARADAY TVE200 TV ENCODER
> M: Linus Walleij <[email protected]>
> S: Maintained
> --
> 2.40.1
>
Hi Paulo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on robh/for-next linus/master v6.4-rc2 next-20230519]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Paulo-Pavacic/dt-bindings-display-panel-add-fannal-c3004/20230519-230337
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230519142456.2588145-2-pavacic.p%40gmail.com
patch subject: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/bb04b236f1d090bd2f7c5780db6ce4f64d83e3b4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Paulo-Pavacic/dt-bindings-display-panel-add-fannal-c3004/20230519-230337
git checkout bb04b236f1d090bd2f7c5780db6ce4f64d83e3b4
make menuconfig
# enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
make htmldocs
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hello Conor,
pet, 19. svi 2023. u 18:41 Conor Dooley <[email protected]> napisao je:
>
> Hey Paulo,
>
> On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote:
> >
> > Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> > Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> > DCS initialization sequences with certain delays between certain
> > commands.
> >
> > Signed-off-by: Paulo Pavacic <[email protected]>
> > ---
> > v3 changelog:
> > - renamed yml file
> > - refactored yml file to describe fannal,c3004
> > - added matrix URI to MAINTAINERS
> > v2 changelog:
> > - revised driver title, now describes purpose
> > - revised description, now describes hw
> > - revised maintainers, now has only 1 mail
> > - removed diacritics from commit/commit author
> > - properties/compatible is now enum
> > - compatible using only lowercase
> > - revised dts example
> > - modified MAINTAINERS in this commit (instead of driver commit)
> > - dt_bindings_check checked yml
> > - checkpatch warning fixed
> > ---
> > .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++
> > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > MAINTAINERS | 6 ++
> > 3 files changed, 83 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > new file mode 100644
> > index 000000000000..a86b5ce02aa2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > @@ -0,0 +1,75 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Fannal C3004 MIPI-DSI
> > +
> > +maintainers:
> > + - Paulo Pavacic <[email protected]>
> > +
> > +description: |
> > + Fannal C3004 is a 480x800 panel which requires DSI DCS
> > + initialization sequences.
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - const: fannal,c3004
> > +
> > + reg: true
>
> Are there no restrictions on the number of reg entries?
What do you mean by this? May I have some example if possible?
>
> > + reset-gpios: true
>
> Can you put a blank line between properties please?
>
> > +
> > + vdd-supply:
> > + description: power supply voltage
> > + vddio-supply:
> > + description: power supply voltage for IO
> > +
> > + width-mm:
> > + description: physical panel width [mm]
> > + height-mm:
> > + description: physical panel height [mm]
>
> Here and for the supplies too.
>
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 82d39ab0231b..f962750f630a 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -462,6 +462,8 @@ patternProperties:
> > description: Facebook
> > "^fairphone,.*":
> > description: Fairphone B.V.
> > + "^fannal,.*":
> > + description: Fannal Electronics Co., Ltd
>
> This needs to be split into a commit of its own.
>
> Thanks,
> Conor.
>
> > "^faraday,.*":
> > description: Faraday Technology Corporation
> > "^fastrax,.*":
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5c22c828ab46..62374c8424b9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc
> > F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
> > F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c
> >
> > +DRM DRIVER FOR FANNAL C3004373132019A
> > +M: Paulo Pavacic <[email protected]>
> > +S: Maintained
> > +C: matrix:r/mipi-dsi-bringup:matrix.org
> > +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml
> > +
> > DRM DRIVER FOR FARADAY TVE200 TV ENCODER
> > M: Linus Walleij <[email protected]>
> > S: Maintained
> > --
> > 2.40.1
> >
Thanks,
Paulo
On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote:
> Hello Conor,
>
> pet, 19. svi 2023. u 18:41 Conor Dooley <[email protected]> napisao je:
> >
> > Hey Paulo,
> >
> > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote:
> > >
> > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> > > DCS initialization sequences with certain delays between certain
> > > commands.
> > >
> > > Signed-off-by: Paulo Pavacic <[email protected]>
> > > ---
> > > v3 changelog:
> > > - renamed yml file
> > > - refactored yml file to describe fannal,c3004
> > > - added matrix URI to MAINTAINERS
> > > v2 changelog:
> > > - revised driver title, now describes purpose
> > > - revised description, now describes hw
> > > - revised maintainers, now has only 1 mail
> > > - removed diacritics from commit/commit author
> > > - properties/compatible is now enum
> > > - compatible using only lowercase
> > > - revised dts example
> > > - modified MAINTAINERS in this commit (instead of driver commit)
> > > - dt_bindings_check checked yml
> > > - checkpatch warning fixed
> > > ---
> > > .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++
> > > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > > MAINTAINERS | 6 ++
> > > 3 files changed, 83 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > new file mode 100644
> > > index 000000000000..a86b5ce02aa2
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > @@ -0,0 +1,75 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Fannal C3004 MIPI-DSI
> > > +
> > > +maintainers:
> > > + - Paulo Pavacic <[email protected]>
> > > +
> > > +description: |
> > > + Fannal C3004 is a 480x800 panel which requires DSI DCS
> > > + initialization sequences.
> > > +
> > > +allOf:
> > > + - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - const: fannal,c3004
> > > +
> > > + reg: true
> >
> > Are there no restrictions on the number of reg entries?
>
> What do you mean by this? May I have some example if possible?
I was commenting on the lack of minItems and/or maxItems.
Cheers,
Conor.
Hello Conor,
pon, 5. lip 2023. u 16:43 Conor Dooley <[email protected]> napisao je:
>
> On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote:
> > Hello Conor,
> >
> > pet, 19. svi 2023. u 18:41 Conor Dooley <[email protected]> napisao je:
> > >
> > > Hey Paulo,
> > >
> > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote:
> > > >
> > > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004.
> > > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires
> > > > DCS initialization sequences with certain delays between certain
> > > > commands.
> > > >
> > > > Signed-off-by: Paulo Pavacic <[email protected]>
> > > > ---
> > > > v3 changelog:
> > > > - renamed yml file
> > > > - refactored yml file to describe fannal,c3004
> > > > - added matrix URI to MAINTAINERS
> > > > v2 changelog:
> > > > - revised driver title, now describes purpose
> > > > - revised description, now describes hw
> > > > - revised maintainers, now has only 1 mail
> > > > - removed diacritics from commit/commit author
> > > > - properties/compatible is now enum
> > > > - compatible using only lowercase
> > > > - revised dts example
> > > > - modified MAINTAINERS in this commit (instead of driver commit)
> > > > - dt_bindings_check checked yml
> > > > - checkpatch warning fixed
> > > > ---
> > > > .../bindings/display/panel/fannal,c3004.yaml | 75 +++++++++++++++++++
> > > > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > > > MAINTAINERS | 6 ++
> > > > 3 files changed, 83 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > > new file mode 100644
> > > > index 000000000000..a86b5ce02aa2
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
> > > > @@ -0,0 +1,75 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Fannal C3004 MIPI-DSI
> > > > +
> > > > +maintainers:
> > > > + - Paulo Pavacic <[email protected]>
> > > > +
> > > > +description: |
> > > > + Fannal C3004 is a 480x800 panel which requires DSI DCS
> > > > + initialization sequences.
> > > > +
> > > > +allOf:
> > > > + - $ref: panel-common.yaml#
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + items:
> > > > + - const: fannal,c3004
> > > > +
> > > > + reg: true
> > >
> > > Are there no restrictions on the number of reg entries?
> >
> > What do you mean by this? May I have some example if possible?
>
> I was commenting on the lack of minItems and/or maxItems.
Sorry this is my first patch, I still don't understand, why should I
add `maxItems: 1` to the 'reg:' ?
Isn't part of the code:
> required:
> - compatible
> - reg
> - reset-gpios
making `minItems: 1` redundant for reg properties?
>
> Cheers,
> Conor.
Thanks,
Paulo
On Mon, Jun 05, 2023 at 04:56:13PM +0200, Paulo Pavacic wrote:
> Hello Conor,
>
> pon, 5. lip 2023. u 16:43 Conor Dooley <[email protected]> napisao je:
> Sorry this is my first patch, I still don't understand, why should I
> add `maxItems: 1` to the 'reg:' ?
> Isn't part of the code:
> > required:
> > - compatible
> > - reg
> > - reset-gpios
>
> making `minItems: 1` redundant for reg properties?
I went and had another look, and you get enforcement of this from the
dsi-controller binding if extra reg entries are added.
Sorry for the noise.