2020-05-13 15:53:48

by Michael Srba

Subject: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

From: Michael Srba <[email protected]>

Attempting to enable these devices causes a "synchronous
external abort". Suspected cause is that the debug power
domain is not enabled by default on this device.
Disable these devices for now to avoid the crash.

See: https://lore.kernel.org/linux-arm-msm/[email protected]/

Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
Signed-off-by: Michael Srba <[email protected]>

---
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 6 ++++++
arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
2 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
index d1ccb9472c8b..28983b871a70 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
@@ -105,6 +105,12 @@ wcnss@a21b000 {
etm@85d000 { status = "disabled"; };
etm@85e000 { status = "disabled"; };
etm@85f000 { status = "disabled"; };
+ cti@810000 { status = "disabled"; };
+ cti@811000 { status = "disabled"; };
+ cti@858000 { status = "disabled"; };
+ cti@859000 { status = "disabled"; };
+ cti@85a000 { status = "disabled"; };
+ cti@85b000 { status = "disabled"; };
};

// FIXME: Use extcon device provided by charger driver when available
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
index 43c5e0f882f1..8569a1532a3f 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
@@ -98,6 +98,12 @@ wcnss@a21b000 {
etm@85d000 { status = "disabled"; };
etm@85e000 { status = "disabled"; };
etm@85f000 { status = "disabled"; };
+ cti@810000 { status = "disabled"; };
+ cti@811000 { status = "disabled"; };
+ cti@858000 { status = "disabled"; };
+ cti@859000 { status = "disabled"; };
+ cti@85a000 { status = "disabled"; };
+ cti@85b000 { status = "disabled"; };
};

gpio-keys {
--
2.24.0

2020-05-13 16:06:33

by Jeffrey Hugo

Subject: Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

On Wed, May 13, 2020 at 9:53 AM <[email protected]> wrote:
>
> From: Michael Srba <[email protected]>
>
> Attempting to enable these devices causes a "synchronous
> external abort". Suspected cause is that the debug power
> domain is not enabled by default on this device.
> Disable these devices for now to avoid the crash.
>
> See: https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
> Signed-off-by: Michael Srba <[email protected]>
>
> ---
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 6 ++++++
> arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
> 2 files changed, 12 insertions(+)

Why are we disabling these in board specific files? Seems like these
should be disabled in the base msm8916.dtsi. Otherwise, the next
board that gets brought up is probably going to hit this same exact
issue.

This also follows the solution that msm8998 did for the same issue.

2020-05-13 16:50:07

by Michael Srba

Subject: Re: [PATCH] arm64: dts: qcom: disable the new cti nodes on devices with broken coresight

On 13. 05. 20 18:04, Jeffrey Hugo wrote:
> On Wed, May 13, 2020 at 9:53 AM <[email protected]> wrote:
>> From: Michael Srba <[email protected]>
>>
>> Attempting to enable these devices causes a "synchronous
>> external abort". Suspected cause is that the debug power
>> domain is not enabled by default on this device.
>> Disable these devices for now to avoid the crash.
>>
>> See: https://lore.kernel.org/linux-arm-msm/[email protected]/
>>
>> Fixes: b1fcc5702a41 ("arm64: dts: qcom: msm8916: Add CTI options")
>> Signed-off-by: Michael Srba <[email protected]>
>>
>> ---
>> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 6 ++++++
>> arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 6 ++++++
>> 2 files changed, 12 insertions(+)
> Why are we disabling these in board specific files? Seems like these
> should be disabled in the base msm8916.dtsi. Otherwise, the next
> board that gets brought up is probably going to hit this same exact
> issue.
>
> This also follows the solution that msm8998 did for the same issue.

I would also advocate for having them disabled by default. I *think* it was
brought up initially, but that would be before the msm8998 change.