2017-11-17 22:28:08

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define

On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
<[email protected]> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
>
> Cc: Patrik Jakobsson <[email protected]>
> Cc: David Airlie <[email protected]>
> Reported-by: Philippe Ombredanne <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>

Reviewed-by: Philippe Ombredanne <[email protected]>

--
Cordially
Philippe Ombredanne

From 1584346781492968359@xxx Fri Nov 17 20:33:53 +0000 2017
X-GM-THRID: 1584346781492968359
X-Gmail-Labels: Inbox,Category Promotions,HistoricalUnread