2017-11-30 11:34:50

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH] riscv/ftrace: Add basic support

On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <[email protected]> wrote:
[]
> diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
> new file mode 100644
> index 000000000000..38beadb07ad5
> --- /dev/null
> +++ b/arch/riscv/include/asm/ftrace.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2017 Andes Technology Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */

You may want to use the new SPDX ids here instead?
e.g.
> +// SPDX-License-Identifer: GPL-2.0
> +// Copyright (C) 2017 Andes Technology Corporation

Neater and simpler?
See Linus posts on the topic of comment styles too BTW

--
Cordially
Philippe Ombredanne

From 1585480628730807362@xxx Thu Nov 30 08:55:54 +0000 2017
X-GM-THRID: 1585480628730807362
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread