2017-11-17 19:22:34

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Fri, Nov 17, 2017 at 3:19 PM, Greg Kroah-Hartman
<[email protected]> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller" <[email protected]>
> Cc: Andreas Kemnade <[email protected]>
> Cc: Johan Hovold <[email protected]>
> Reported-by: Philippe Ombredanne <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>


Reviewed-by: Philippe Ombredanne <[email protected]>
--
Cordially
Philippe Ombredanne

From 1584341954256791576@xxx Fri Nov 17 19:17:10 +0000 2017
X-GM-THRID: 1584341954256791576
X-Gmail-Labels: Inbox,Category Promotions,HistoricalUnread