2021-08-26 12:05:20

by Colin King

Subject: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

From: Colin Ian King <[email protected]>

There are spelling mistakes in dev_err and dev_info messages. Fix them.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
index 163efab27e9b..5060d3998889 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
@@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
write_unlock_bh(&ctbl->lock);
dev_err(adap->pdev_dev,
"CLIP FW cmd failed with error %d, "
- "Connections using %pI6c wont be "
+ "Connections using %pI6c won't be "
"offloaded",
ret, ce->addr6.sin6_addr.s6_addr);
return ret;
@@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
} else {
write_unlock_bh(&ctbl->lock);
dev_info(adap->pdev_dev, "CLIP table overflow, "
- "Connections using %pI6c wont be offloaded",
+ "Connections using %pI6c won't be offloaded",
(void *)lip);
return -ENOMEM;
}
--
2.32.0

2021-08-26 14:53:47

by Joe Perches

Subject: Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> ? write_unlock_bh(&ctbl->lock);
> ?1 file changed, 2 insertions(+), 2 deletions(-)
> ? dev_err(adap->pdev_dev,
> ? "CLIP FW cmd failed with error %d, "
> - "Connections using %pI6c wont be "
> + "Connections using %pI6c won't be "
> ? "offloaded",
> ? ret, ce->addr6.sin6_addr.s6_addr);
> ? return ret;
> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> ? } else {
> ? write_unlock_bh(&ctbl->lock);
> ? dev_info(adap->pdev_dev, "CLIP table overflow, "
> - "Connections using %pI6c wont be offloaded",
> + "Connections using %pI6c won't be offloaded",
> ? (void *)lip);

This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.

2021-08-26 15:22:50

by Denis Kirjanov

Subject: Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

On 8/26/21, Joe Perches <[email protected]> wrote:
> On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> There are spelling mistakes in dev_err and dev_info messages. Fix them.
> []
>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
>> b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
> []
>> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> write_unlock_bh(&ctbl->lock);
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> dev_err(adap->pdev_dev,
>> "CLIP FW cmd failed with error %d, "
>> - "Connections using %pI6c wont be "
>> + "Connections using %pI6c won't be "
>> "offloaded",
>> ret, ce->addr6.sin6_addr.s6_addr);
>> return ret;
>> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> } else {
>> write_unlock_bh(&ctbl->lock);
>> dev_info(adap->pdev_dev, "CLIP table overflow, "
>> - "Connections using %pI6c wont be offloaded",
>> + "Connections using %pI6c won't be offloaded",
>> (void *)lip);
>
> This is an unnecessary cast.
> And these could coalesce the format fragments and add newlines too.

and fix the leftover in the comment:
./t4_hw.c:7185: * set wont be sent when we are flashing FW.


>
>
>