LinuxLists.cc - [PATCH] ALSA: compress: add opus codec define

2023-07-25 10:13:12

Subject: [PATCH] ALSA: compress: add opus codec define

Add to support decode Opus codec in Ogg container.

Signed-off-by: Robert Lee <[email protected]>
---
include/uapi/sound/compress_params.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
index ddc77322d571..bac5797bcb02 100644
--- a/include/uapi/sound/compress_params.h
+++ b/include/uapi/sound/compress_params.h
@@ -43,7 +43,8 @@
#define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
#define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
#define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS

/*
* Profile and modes are listed with bit masks. This allows for a
--
2.41.0.487.g6d72f3e995-goog

2023-07-25 10:54:18

by Robert Lee

[permalink] [raw]

Subject: Re: [PATCH] ALSA: compress: add opus codec define

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm
driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日週二下午6:05寫道：
>
> On Tue, 25 Jul 2023 11:30:05 +0200,
> Robert Lee wrote:
> >
> > Add to support decode Opus codec in Ogg container.
> >
> > Signed-off-by: Robert Lee <[email protected]>
>
> The change makes sense only when it's really used. So usually it's
> better to put into a series that actually implements its usage.
>
>
> thanks,
>
> Takashi
>
> > ---
> > include/uapi/sound/compress_params.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > index ddc77322d571..bac5797bcb02 100644
> > --- a/include/uapi/sound/compress_params.h
> > +++ b/include/uapi/sound/compress_params.h
> > @@ -43,7 +43,8 @@
> > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
> > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
> > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
> > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
> > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
> > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS
> >
> > /*
> > * Profile and modes are listed with bit masks. This allows for a
> > --
> > 2.41.0.487.g6d72f3e995-goog
> >

2023-07-25 10:54:36

by Takashi Iwai

[permalink] [raw]

Subject: Re: [PATCH] ALSA: compress: add opus codec define

On Tue, 25 Jul 2023 11:30:05 +0200,
Robert Lee wrote:
>
> Add to support decode Opus codec in Ogg container.
>
> Signed-off-by: Robert Lee <[email protected]>

The change makes sense only when it's really used. So usually it's
better to put into a series that actually implements its usage.

thanks,

Takashi

> ---
> include/uapi/sound/compress_params.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> index ddc77322d571..bac5797bcb02 100644
> --- a/include/uapi/sound/compress_params.h
> +++ b/include/uapi/sound/compress_params.h
> @@ -43,7 +43,8 @@
> #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
> #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
> #define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
> -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
> +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
> +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS
>
> /*
> * Profile and modes are listed with bit masks. This allows for a
> --
> 2.41.0.487.g6d72f3e995-goog
>

2023-07-25 10:55:04

by Takashi Iwai

[permalink] [raw]

Subject: Re: [PATCH] ALSA: compress: add opus codec define

On Tue, 25 Jul 2023 12:14:56 +0200,
Robert Lee wrote:
>
> Thanks for reply so quickly.
> And yes, there are other changes but it is inside our offload pcm
> driver to handle it.
> Currently we only use it to decode, and we don't need additional option for it.

It means still a downstream-only change :)

It's nice to upstream changes in general, but from the upstream POV,
only changing this gives no benefit. Let's tie with the actual use
case *in the upstream*.

thanks,

Takashi

>
> Thanks,
> Robert.
>
> Takashi Iwai <[email protected]> $B1w(B 2023$BG/(B7$B7n(B25$BF|(B $B=5Fs(B $B2<8a(B6:05$BUmF;!'(B
> >
> > On Tue, 25 Jul 2023 11:30:05 +0200,
> > Robert Lee wrote:
> > >
> > > Add to support decode Opus codec in Ogg container.
> > >
> > > Signed-off-by: Robert Lee <[email protected]>
> >
> > The change makes sense only when it's really used. So usually it's
> > better to put into a series that actually implements its usage.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > > ---
> > > include/uapi/sound/compress_params.h | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > > index ddc77322d571..bac5797bcb02 100644
> > > --- a/include/uapi/sound/compress_params.h
> > > +++ b/include/uapi/sound/compress_params.h
> > > @@ -43,7 +43,8 @@
> > > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
> > > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
> > > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
> > > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
> > > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
> > > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS
> > >
> > > /*
> > > * Profile and modes are listed with bit masks. This allows for a
> > > --
> > > 2.41.0.487.g6d72f3e995-goog
> > >
>

2023-07-26 01:58:04

by Robert Lee

[permalink] [raw]

Subject: Re: [PATCH] ALSA: compress: add opus codec define

Yes, but we still need this change to let the sound system can use the
codec. or do you have any suggestions?

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日週二下午6:25寫道：
>
> On Tue, 25 Jul 2023 12:14:56 +0200,
> Robert Lee wrote:
> >
> > Thanks for reply so quickly.
> > And yes, there are other changes but it is inside our offload pcm
> > driver to handle it.
> > Currently we only use it to decode, and we don't need additional option for it.
>
> It means still a downstream-only change :)
>
> It's nice to upstream changes in general, but from the upstream POV,
> only changing this gives no benefit. Let's tie with the actual use
> case *in the upstream*.
>
>
> thanks,
>
> Takashi
>
> >
> > Thanks,
> > Robert.
> >
> > Takashi Iwai <[email protected]> 於 2023年7月25日週二下午6:05寫道：
> > >
> > > On Tue, 25 Jul 2023 11:30:05 +0200,
> > > Robert Lee wrote:
> > > >
> > > > Add to support decode Opus codec in Ogg container.
> > > >
> > > > Signed-off-by: Robert Lee <[email protected]>
> > >
> > > The change makes sense only when it's really used. So usually it's
> > > better to put into a series that actually implements its usage.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > > > ---
> > > > include/uapi/sound/compress_params.h | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > > > index ddc77322d571..bac5797bcb02 100644
> > > > --- a/include/uapi/sound/compress_params.h
> > > > +++ b/include/uapi/sound/compress_params.h
> > > > @@ -43,7 +43,8 @@
> > > > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
> > > > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
> > > > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
> > > > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
> > > > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
> > > > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS
> > > >
> > > > /*
> > > > * Profile and modes are listed with bit masks. This allows for a
> > > > --
> > > > 2.41.0.487.g6d72f3e995-goog
> > > >
> >

2023-07-26 05:32:00

by Vinod Koul

[permalink] [raw]

Subject: Re: [PATCH] ALSA: compress: add opus codec define

On 26-07-23, 09:47, Robert Lee wrote:

Please stop top posting!

> Yes, but we still need this change to let the sound system can use the
> codec. or do you have any suggestions?

Upstream your driver along with this change should be the way to go

>
> Thanks,
> Robert.
>
> Takashi Iwai <[email protected]> 於 2023年7月25日週二下午6:25寫道：
> >
> > On Tue, 25 Jul 2023 12:14:56 +0200,
> > Robert Lee wrote:
> > >
> > > Thanks for reply so quickly.
> > > And yes, there are other changes but it is inside our offload pcm
> > > driver to handle it.
> > > Currently we only use it to decode, and we don't need additional option for it.
> >
> > It means still a downstream-only change :)
> >
> > It's nice to upstream changes in general, but from the upstream POV,
> > only changing this gives no benefit. Let's tie with the actual use
> > case *in the upstream*.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > > Thanks,
> > > Robert.
> > >
> > > Takashi Iwai <[email protected]> 於 2023年7月25日週二下午6:05寫道：
> > > >
> > > > On Tue, 25 Jul 2023 11:30:05 +0200,
> > > > Robert Lee wrote:
> > > > >
> > > > > Add to support decode Opus codec in Ogg container.
> > > > >
> > > > > Signed-off-by: Robert Lee <[email protected]>
> > > >
> > > > The change makes sense only when it's really used. So usually it's
> > > > better to put into a series that actually implements its usage.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > > > > ---
> > > > > include/uapi/sound/compress_params.h | 3 ++-
> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> > > > > index ddc77322d571..bac5797bcb02 100644
> > > > > --- a/include/uapi/sound/compress_params.h
> > > > > +++ b/include/uapi/sound/compress_params.h
> > > > > @@ -43,7 +43,8 @@
> > > > > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E)
> > > > > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F)
> > > > > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010)
> > > > > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE
> > > > > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011)
> > > > > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS
> > > > >
> > > > > /*
> > > > > * Profile and modes are listed with bit masks. This allows for a
> > > > > --
> > > > > 2.41.0.487.g6d72f3e995-goog
> > > > >
> > >

--
~Vinod