Headphone detection is triggered by GPIO, then driver can
switch between speaker and headphone.
Signed-off-by: Shengjiu Wang <[email protected]>
---
arch/arm/boot/dts/imx6sx-sdb.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
index 3e5fb72f21fc..15f486a15f24 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
@@ -165,6 +165,7 @@ sound {
"IN3R", "AMIC";
mux-int-port = <2>;
mux-ext-port = <6>;
+ hp-det-gpio = <&gpio1 17 GPIO_ACTIVE_LOW>;
};
panel {
@@ -374,6 +375,9 @@ &wdog1 {
&iomuxc {
imx6x-sdb {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_hog>;
+
pinctrl_audmux: audmuxgrp {
fsl,pins = <
MX6SX_PAD_CSI_DATA00__AUDMUX_AUD6_TXC 0x130b0
@@ -450,6 +454,12 @@ MX6SX_PAD_CSI_DATA05__GPIO1_IO_19 0x17059
>;
};
+ pinctrl_hog: hoggrp {
+ fsl,pins = <
+ MX6SX_PAD_CSI_DATA03__GPIO1_IO_17 0x17059
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX6SX_PAD_GPIO1_IO01__I2C1_SDA 0x4001b8b1
--
2.27.0
Hi Shengjiu,
On Thu, Aug 6, 2020 at 8:55 AM Shengjiu Wang <[email protected]> wrote:
> &iomuxc {
> imx6x-sdb {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hog>;
Instead of adding a hog group, please add the headphone detect GPIO
under the audmux group like you did in the imx6sl-evk patch.
Thanks
> > &iomuxc {
> > imx6x-sdb {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_hog>;
>
> Instead of adding a hog group, please add the headphone detect GPIO under
> the audmux group like you did in the imx6sl-evk patch.
>
I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
Still in hog group.
And I think headphone detect GPIO is not belong to audmux group, it should
Be in hog group.
Best regards
Wang shengjiu
On Mon, Aug 17, 2020 at 10:57 AM S.j. Wang <[email protected]> wrote:
> I didn't put headphone detect GPIO in audmux group in imx6sl-evk patch,
> Still in hog group.
Ok, sorry. You grouped it with MX6SL_PAD_AUD_MCLK__AUDIO_CLK_OUT,
which I also think should not be part of the hog group.
> And I think headphone detect GPIO is not belong to audmux group, it should
> Be in hog group.
The hog group is better suited when there is no driver that can be
associated with that particular pin.
For the headphone GPIO detect, I think it makes sense to group it with
the other audio-related pinctrl pins.
Hi Shawn
>
> > I didn't put headphone detect GPIO in audmux group in imx6sl-evk
> > patch, Still in hog group.
>
> Ok, sorry. You grouped it with MX6SL_PAD_AUD_MCLK__AUDIO_CLK_OUT,
> which I also think should not be part of the hog group.
>
> > And I think headphone detect GPIO is not belong to audmux group, it
> > should Be in hog group.
>
> The hog group is better suited when there is no driver that can be associated
> with that particular pin.
>
> For the headphone GPIO detect, I think it makes sense to group it with the
> other audio-related pinctrl pins.
I would like to know your opinion, should I move headphone detect GPIO
To audmux group?
Best regards
Wang shengjiu
Hi Wang Shengjiu and Shawn,
On Sun, Aug 23, 2020 at 9:31 AM S.j. Wang <[email protected]> wrote:
> I would like to know your opinion, should I move headphone detect GPIO
> To audmux group?
What about adding a dedicated pinctrl_hp for the headphone detect pin
like it is done at:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi?h=for-next&id=8f0216b006e5f553d28c4c1a991b5234693a49cb#n130
My point is that we should avoid adding a hog group when possible.
Thanks
On Sun, Aug 23, 2020 at 11:12:08AM -0300, Fabio Estevam wrote:
> Hi Wang Shengjiu and Shawn,
>
> On Sun, Aug 23, 2020 at 9:31 AM S.j. Wang <[email protected]> wrote:
>
> > I would like to know your opinion, should I move headphone detect GPIO
> > To audmux group?
>
> What about adding a dedicated pinctrl_hp for the headphone detect pin
> like it is done at:
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi?h=for-next&id=8f0216b006e5f553d28c4c1a991b5234693a49cb#n130
>
> My point is that we should avoid adding a hog group when possible.
I agree. Hog group should be used as the last sort, when there is no
clear client device owning the pins.
Shawn
Hi Shawn, Fabio
> >
> > > I would like to know your opinion, should I move headphone detect
> > > GPIO To audmux group?
> >
> > What about adding a dedicated pinctrl_hp for the headphone detect pin
> > like it is done at:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fshawnguo%2Flinux.g
> it%2
> > Ftree%2Farch%2Farm64%2Fboot%2Fdts%2Ffreescale%2Fimx8mq-
> librem5.dtsi%3F
> > h%3Dfor-
> next%26id%3D8f0216b006e5f553d28c4c1a991b5234693a49cb%23n130&am
> >
> p;data=02%7C01%7Cshengjiu.wang%40nxp.com%7C672e70414ead4170b617
> 08d847c
> >
> 05117%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63733823860
> 3810133&
> >
> amp;sdata=69K7rVsYB35Iq%2FdE%2FSf2%2B862VlwOFRwSTYBML7OQxUE%3
> D&res
> > erved=0
> >
> > My point is that we should avoid adding a hog group when possible.
>
> I agree. Hog group should be used as the last sort, when there is no clear
> client device owning the pins.
>
Ok, thanks. I have sent v2. That I refined three patches for this topic.
ARM: dts: imx6sx-sdb: Add headphone detection for sound card
ARM: dts: imx6sl-evk: Add headphone detection for sound card
ARM: dts: imx6sll-evk: Add audio sound card node
Best regards
Wang shengjiu