2021-11-11 08:40:15

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config

Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
the non-existing config ARCH_MXC_ARM64.

Hence, ./scripts/checkkconfigsymbols.py warns:

ARCH_MXC_ARM64
Referencing files: drivers/iio/adc/Kconfig

Probably, the existing config ARCH_MXC is intended to be referred here.
So, repair the dependency to refer to that config.

Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/iio/adc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 8bf5b62a73f4..3363af15a43f 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -532,7 +532,7 @@ config IMX7D_ADC

config IMX8QXP_ADC
tristate "NXP IMX8QXP ADC driver"
- depends on ARCH_MXC_ARM64 || COMPILE_TEST
+ depends on ARCH_MXC || COMPILE_TEST
depends on HAS_IOMEM
help
Say yes here to build support for IMX8QXP ADC.
--
2.26.2



2021-11-11 10:31:42

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config

Hi Lukas,

On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <[email protected]> wrote:
>
> Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> the non-existing config ARCH_MXC_ARM64.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> ARCH_MXC_ARM64
> Referencing files: drivers/iio/adc/Kconfig
>
> Probably, the existing config ARCH_MXC is intended to be referred here.
> So, repair the dependency to refer to that config.
>
> Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> Signed-off-by: Lukas Bulwahn <[email protected]>

This looks good.

The incorrect ARCH_MXC_ARM64 symbol probably came when porting the
driver from the NXP downstream kernel:

Reviewed-by: Fabio Estevam <[email protected]>

2021-11-12 16:15:36

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: imx8qxp-adc: fix dependency to the intended ARCH_MXC config

On Thu, 11 Nov 2021 07:31:25 -0300
Fabio Estevam <[email protected]> wrote:

> Hi Lukas,
>
> On Thu, Nov 11, 2021 at 5:40 AM Lukas Bulwahn <[email protected]> wrote:
> >
> > Commit 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP
> > ADC") adds the config IMX8QXP_ADC for this new driver, which depends on
> > the non-existing config ARCH_MXC_ARM64.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns:
> >
> > ARCH_MXC_ARM64
> > Referencing files: drivers/iio/adc/Kconfig
> >
> > Probably, the existing config ARCH_MXC is intended to be referred here.
> > So, repair the dependency to refer to that config.
> >
> > Fixes: 1e23dcaa1a9f ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> > Signed-off-by: Lukas Bulwahn <[email protected]>
>
> This looks good.
>
> The incorrect ARCH_MXC_ARM64 symbol probably came when porting the
> driver from the NXP downstream kernel:
>
> Reviewed-by: Fabio Estevam <[email protected]>
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan