2024-05-02 21:58:36

by Christian Gmeiner

Subject: [PATCH] arm64: dts: imx8qm: Add GPU nodes

From: Christian Gmeiner <[email protected]>

Add the DT node for the GPU core found on the i.MX8QM.

etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
[drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0

Signed-off-by: Christian Gmeiner <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index b3d01677b70c..54879ae1d7d5 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -467,6 +467,7 @@ drc_crit0: trip1 {
#include "imx8-ss-dma.dtsi"
#include "imx8-ss-conn.dtsi"
#include "imx8-ss-lsio.dtsi"
+ #include "imx8-ss-gpu0.dtsi"
};

#include "imx8qm-ss-img.dtsi"
--
2.44.0

2024-05-02 23:02:45

by Fabio Estevam

Subject: Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes

Hi Christian,

On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
<[email protected]> wrote:
>
> From: Christian Gmeiner <[email protected]>
>
> Add the DT node for the GPU core found on the i.MX8QM.
>
> etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
>
> Signed-off-by: Christian Gmeiner <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index b3d01677b70c..54879ae1d7d5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> #include "imx8-ss-dma.dtsi"
> #include "imx8-ss-conn.dtsi"
> #include "imx8-ss-lsio.dtsi"
> + #include "imx8-ss-gpu0.dtsi"

Nit: better put it in alphabetical order.

Reviewed-by: Fabio Estevam <[email protected]>

2024-05-03 03:08:25

by Frank Li

Subject: Re: [PATCH] arm64: dts: imx8qm: Add GPU nodes

On Thu, May 02, 2024 at 08:01:37PM -0300, Fabio Estevam wrote:
> Hi Christian,
>
> On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
> <[email protected]> wrote:
> >
> > From: Christian Gmeiner <[email protected]>
> >
> > Add the DT node for the GPU core found on the i.MX8QM.
> >
> > etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> > [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
> >
> > Signed-off-by: Christian Gmeiner <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index b3d01677b70c..54879ae1d7d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> > #include "imx8-ss-dma.dtsi"
> > #include "imx8-ss-conn.dtsi"
> > #include "imx8-ss-lsio.dtsi"
> > + #include "imx8-ss-gpu0.dtsi"
>
> Nit: better put it in alphabetical order.

No, it should be order by subsystem register address. gpu is 53100000.
should be between imx8-ss-vpu and imx8-ss-img.

Frank

>
> Reviewed-by: Fabio Estevam <[email protected]>