2023-11-24 02:13:49

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the vfs-brauner tree

---

Hi all,

After merging the vfs-brauner tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/filesystems/api-summary:14: include/linux/fs.h:1655: WARNING: Definition list ends without a blank line; unexpected unindent.
include/linux/fs.h:1658: warning: Function parameter or member 'level' not described in '__sb_write_started'

Introduced by commit

2a7b49f698d0 ("fs: create __sb_write_started() helper")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-11-24 07:58:43

by Amir Goldstein

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the vfs-brauner tree

---

On Fri, Nov 24, 2023 at 4:13 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/api-summary:14: include/linux/fs.h:1655: WARNING: Definition list ends without a blank line; unexpected unindent.
> include/linux/fs.h:1658: warning: Function parameter or member 'level' not described in '__sb_write_started'
>
> Introduced by commit
>
> 2a7b49f698d0 ("fs: create __sb_write_started() helper")

Christian,

Do you mind folding:

@@ -1648,6 +1648,7 @@ static inline bool
__sb_start_write_trylock(struct super_block *sb, int level)
/**
* __sb_write_started - check if sb freeze level is held
* @sb: the super we write to
+ * @level: the freeze level
*
* > 0 sb freeze level is held
* 0 sb freeze level is not held

Thanks,
Amir.