2022-02-15 12:42:10

by hammer hsieh

[permalink] [raw]
Subject: [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver

Add bindings doc for Sunplus SoC UART Driver

Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Hammer Hsieh <[email protected]>
---
Changes in v8:
- no change.

.../bindings/serial/sunplus,sp7021-uart.yaml | 56 ++++++++++++++++++++++
MAINTAINERS | 5 ++
2 files changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml

diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
new file mode 100644
index 0000000..894324c
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd. 2021
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
+
+maintainers:
+ - Hammer Hsieh <[email protected]>
+
+allOf:
+ - $ref: serial.yaml#
+
+properties:
+ compatible:
+ const: sunplus,sp7021-uart
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - resets
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ aliases {
+ serial0 = &uart0;
+ };
+
+ uart0: serial@9c000900 {
+ compatible = "sunplus,sp7021-uart";
+ reg = <0x9c000900 0x80>;
+ interrupt-parent = <&intc>;
+ interrupts = <53 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clkc 0x28>;
+ resets = <&rstc 0x18>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 3b79fd4..3c1362e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17945,6 +17945,11 @@ L: [email protected]
S: Maintained
F: drivers/net/ethernet/dlink/sundance.c

+SUNPLUS UART DRIVER
+M: Hammer Hsieh <[email protected]>
+S: Maintained
+F: Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
+
SUPERH
M: Yoshinori Sato <[email protected]>
M: Rich Felker <[email protected]>
--
2.7.4


2022-02-15 16:01:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver

On 15/02/2022 10:24, Hammer Hsieh wrote:
> Add bindings doc for Sunplus SoC UART Driver
>
> Reviewed-by: Rob Herring <[email protected]>
> Signed-off-by: Hammer Hsieh <[email protected]>
> ---
> Changes in v8:
> - no change.
>
> .../bindings/serial/sunplus,sp7021-uart.yaml | 56 ++++++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> new file mode 100644
> index 0000000..894324c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
> +
> +maintainers:
> + - Hammer Hsieh <[email protected]>
> +
> +allOf:
> + - $ref: serial.yaml#
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + aliases {
> + serial0 = &uart0;

Incorrect indentation. With this fixed:

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-02-16 06:49:59

by hammer hsieh

[permalink] [raw]
Subject: Re: [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver

Krzysztof Kozlowski <[email protected]> 於 2022年2月15日
週二 下午10:53寫道:
>
> On 15/02/2022 10:24, Hammer Hsieh wrote:
> > Add bindings doc for Sunplus SoC UART Driver
> >
> > Reviewed-by: Rob Herring <[email protected]>
> > Signed-off-by: Hammer Hsieh <[email protected]>
> > ---
> > Changes in v8:
> > - no change.
> >
> > .../bindings/serial/sunplus,sp7021-uart.yaml | 56 ++++++++++++++++++++++
> > MAINTAINERS | 5 ++
> > 2 files changed, 61 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> > new file mode 100644
> > index 0000000..894324c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) Sunplus Co., Ltd. 2021
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Hammer Hsieh <[email protected]>
> > +
> > +allOf:
> > + - $ref: serial.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: sunplus,sp7021-uart
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - resets
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + aliases {
> > + serial0 = &uart0;
>
> Incorrect indentation. With this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
>
> Best regards,
> Krzysztof

OK, will modify it. Thanks.

Regards,
Hammer