2023-04-29 19:47:20

by Robert Marko

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

Add SOC IDs for the IPQ5018 family.

Signed-off-by: Robert Marko <[email protected]>
---
include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 802495b20276..c1283bad81e1 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -216,6 +216,9 @@
#define QCOM_ID_SM8350 439
#define QCOM_ID_QCM2290 441
#define QCOM_ID_SM6115 444
+#define QCOM_ID_IPQ5010 446
+#define QCOM_ID_IPQ5018 447
+#define QCOM_ID_IPQ5028 448
#define QCOM_ID_SC8280XP 449
#define QCOM_ID_IPQ6005 453
#define QCOM_ID_QRB5165 455
@@ -229,6 +232,9 @@
#define QCOM_ID_SM8450_3 482
#define QCOM_ID_SC7280 487
#define QCOM_ID_SC7180P 495
+#define QCOM_ID_IPQ5000 503
+#define QCOM_ID_IPQ0509 504
+#define QCOM_ID_IPQ0518 505
#define QCOM_ID_SM6375 507
#define QCOM_ID_IPQ9514 510
#define QCOM_ID_IPQ9550 511
@@ -236,6 +242,7 @@
#define QCOM_ID_IPQ9570 513
#define QCOM_ID_IPQ9574 514
#define QCOM_ID_SM8550 519
+#define QCOM_ID_IPQ5016 520
#define QCOM_ID_IPQ9510 521
#define QCOM_ID_QRB4210 523
#define QCOM_ID_QRB2210 524
@@ -243,6 +250,7 @@
#define QCOM_ID_QRU1000 539
#define QCOM_ID_QDU1000 545
#define QCOM_ID_QDU1010 587
+#define QCOM_ID_IPQ5019 569
#define QCOM_ID_QRU1032 588
#define QCOM_ID_QRU1052 589
#define QCOM_ID_QRU1062 590
--
2.40.1


2023-04-29 19:48:11

by Robert Marko

[permalink] [raw]
Subject: [PATCH 2/2] soc: qcom: socinfo: Add IDs for IPQ5018 family

Add SOC IDs for the IPQ5018 family.

Signed-off-by: Robert Marko <[email protected]>
---
drivers/soc/qcom/socinfo.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index c2e4a57dd666..c61a93b4dcaf 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -434,6 +434,9 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(SM8350) },
{ qcom_board_id(QCM2290) },
{ qcom_board_id(SM6115) },
+ { qcom_board_id(IPQ5010) },
+ { qcom_board_id(IPQ5018) },
+ { qcom_board_id(IPQ5028) },
{ qcom_board_id(SC8280XP) },
{ qcom_board_id(IPQ6005) },
{ qcom_board_id(QRB5165) },
@@ -447,6 +450,9 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id_named(SM8450_3, "SM8450") },
{ qcom_board_id(SC7280) },
{ qcom_board_id(SC7180P) },
+ { qcom_board_id(IPQ5000) },
+ { qcom_board_id(IPQ0509) },
+ { qcom_board_id(IPQ0518) },
{ qcom_board_id(SM6375) },
{ qcom_board_id(IPQ9514) },
{ qcom_board_id(IPQ9550) },
@@ -454,6 +460,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(IPQ9570) },
{ qcom_board_id(IPQ9574) },
{ qcom_board_id(SM8550) },
+ { qcom_board_id(IPQ5016) },
{ qcom_board_id(IPQ9510) },
{ qcom_board_id(QRB4210) },
{ qcom_board_id(QRB2210) },
@@ -461,6 +468,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(QRU1000) },
{ qcom_board_id(QDU1000) },
{ qcom_board_id(QDU1010) },
+ { qcom_board_id(IPQ5019) },
{ qcom_board_id(QRU1032) },
{ qcom_board_id(QRU1052) },
{ qcom_board_id(QRU1062) },
--
2.40.1

2023-05-01 06:51:55

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

On 29/04/2023 21:33, Robert Marko wrote:
> Add SOC IDs for the IPQ5018 family.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
> include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
> 1 file changed, 8 insertions(+)

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-05-01 06:52:07

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] soc: qcom: socinfo: Add IDs for IPQ5018 family

On 29/04/2023 21:33, Robert Marko wrote:
> Add SOC IDs for the IPQ5018 family.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
> drivers/soc/qcom/socinfo.c | 8 ++++++++

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-05-01 12:58:13

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family



On 29.04.2023 21:33, Robert Marko wrote:
> Add SOC IDs for the IPQ5018 family.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
> include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index 802495b20276..c1283bad81e1 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -216,6 +216,9 @@
> #define QCOM_ID_SM8350 439
> #define QCOM_ID_QCM2290 441
> #define QCOM_ID_SM6115 444
> +#define QCOM_ID_IPQ5010 446
> +#define QCOM_ID_IPQ5018 447
> +#define QCOM_ID_IPQ5028 448
> #define QCOM_ID_SC8280XP 449
> #define QCOM_ID_IPQ6005 453
> #define QCOM_ID_QRB5165 455
> @@ -229,6 +232,9 @@
> #define QCOM_ID_SM8450_3 482
> #define QCOM_ID_SC7280 487
> #define QCOM_ID_SC7180P 495
> +#define QCOM_ID_IPQ5000 503

> +#define QCOM_ID_IPQ0509 504
> +#define QCOM_ID_IPQ0518 505
Are you sure these names are in tact?

Konrad
> #define QCOM_ID_SM6375 507
> #define QCOM_ID_IPQ9514 510
> #define QCOM_ID_IPQ9550 511
> @@ -236,6 +242,7 @@
> #define QCOM_ID_IPQ9570 513
> #define QCOM_ID_IPQ9574 514
> #define QCOM_ID_SM8550 519
> +#define QCOM_ID_IPQ5016 520
> #define QCOM_ID_IPQ9510 521
> #define QCOM_ID_QRB4210 523
> #define QCOM_ID_QRB2210 524
> @@ -243,6 +250,7 @@
> #define QCOM_ID_QRU1000 539
> #define QCOM_ID_QDU1000 545
> #define QCOM_ID_QDU1010 587
> +#define QCOM_ID_IPQ5019 569
> #define QCOM_ID_QRU1032 588
> #define QCOM_ID_QRU1052 589
> #define QCOM_ID_QRU1062 590

2023-05-01 21:24:50

by Robert Marko

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

On Mon, 1 May 2023 at 14:51, Konrad Dybcio <[email protected]> wrote:
>
>
>
> On 29.04.2023 21:33, Robert Marko wrote:
> > Add SOC IDs for the IPQ5018 family.
> >
> > Signed-off-by: Robert Marko <[email protected]>
> > ---
> > include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> > index 802495b20276..c1283bad81e1 100644
> > --- a/include/dt-bindings/arm/qcom,ids.h
> > +++ b/include/dt-bindings/arm/qcom,ids.h
> > @@ -216,6 +216,9 @@
> > #define QCOM_ID_SM8350 439
> > #define QCOM_ID_QCM2290 441
> > #define QCOM_ID_SM6115 444
> > +#define QCOM_ID_IPQ5010 446
> > +#define QCOM_ID_IPQ5018 447
> > +#define QCOM_ID_IPQ5028 448
> > #define QCOM_ID_SC8280XP 449
> > #define QCOM_ID_IPQ6005 453
> > #define QCOM_ID_QRB5165 455
> > @@ -229,6 +232,9 @@
> > #define QCOM_ID_SM8450_3 482
> > #define QCOM_ID_SC7280 487
> > #define QCOM_ID_SC7180P 495
> > +#define QCOM_ID_IPQ5000 503
>
> > +#define QCOM_ID_IPQ0509 504
> > +#define QCOM_ID_IPQ0518 505
> Are you sure these names are in tact?

Hi,
They should be correct, I am seeing them being used downstream
and in end products as well, IPQ0509 being one of those weird ones
that integrate 256MB of RAM on the die as well.

Regards,
Robert

>
> Konrad
> > #define QCOM_ID_SM6375 507
> > #define QCOM_ID_IPQ9514 510
> > #define QCOM_ID_IPQ9550 511
> > @@ -236,6 +242,7 @@
> > #define QCOM_ID_IPQ9570 513
> > #define QCOM_ID_IPQ9574 514
> > #define QCOM_ID_SM8550 519
> > +#define QCOM_ID_IPQ5016 520
> > #define QCOM_ID_IPQ9510 521
> > #define QCOM_ID_QRB4210 523
> > #define QCOM_ID_QRB2210 524
> > @@ -243,6 +250,7 @@
> > #define QCOM_ID_QRU1000 539
> > #define QCOM_ID_QDU1000 545
> > #define QCOM_ID_QDU1010 587
> > +#define QCOM_ID_IPQ5019 569
> > #define QCOM_ID_QRU1032 588
> > #define QCOM_ID_QRU1052 589
> > #define QCOM_ID_QRU1062 590

2023-05-02 07:06:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

On 01/05/2023 14:51, Konrad Dybcio wrote:
>
>
> On 29.04.2023 21:33, Robert Marko wrote:
>> Add SOC IDs for the IPQ5018 family.
>>
>> Signed-off-by: Robert Marko <[email protected]>
>> ---
>> include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> index 802495b20276..c1283bad81e1 100644
>> --- a/include/dt-bindings/arm/qcom,ids.h
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -216,6 +216,9 @@
>> #define QCOM_ID_SM8350 439
>> #define QCOM_ID_QCM2290 441
>> #define QCOM_ID_SM6115 444
>> +#define QCOM_ID_IPQ5010 446
>> +#define QCOM_ID_IPQ5018 447
>> +#define QCOM_ID_IPQ5028 448
>> #define QCOM_ID_SC8280XP 449
>> #define QCOM_ID_IPQ6005 453
>> #define QCOM_ID_QRB5165 455
>> @@ -229,6 +232,9 @@
>> #define QCOM_ID_SM8450_3 482
>> #define QCOM_ID_SC7280 487
>> #define QCOM_ID_SC7180P 495
>> +#define QCOM_ID_IPQ5000 503
>
>> +#define QCOM_ID_IPQ0509 504
>> +#define QCOM_ID_IPQ0518 505
> Are you sure these names are in tact?

Good catch :)

Best regards,
Krzysztof

2023-05-02 09:53:48

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family



On 1.05.2023 23:22, Robert Marko wrote:
> On Mon, 1 May 2023 at 14:51, Konrad Dybcio <[email protected]> wrote:
>>
>>
>>
>> On 29.04.2023 21:33, Robert Marko wrote:
>>> Add SOC IDs for the IPQ5018 family.
>>>
>>> Signed-off-by: Robert Marko <[email protected]>
>>> ---
>>> include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>>> index 802495b20276..c1283bad81e1 100644
>>> --- a/include/dt-bindings/arm/qcom,ids.h
>>> +++ b/include/dt-bindings/arm/qcom,ids.h
>>> @@ -216,6 +216,9 @@
>>> #define QCOM_ID_SM8350 439
>>> #define QCOM_ID_QCM2290 441
>>> #define QCOM_ID_SM6115 444
>>> +#define QCOM_ID_IPQ5010 446
>>> +#define QCOM_ID_IPQ5018 447
>>> +#define QCOM_ID_IPQ5028 448
>>> #define QCOM_ID_SC8280XP 449
>>> #define QCOM_ID_IPQ6005 453
>>> #define QCOM_ID_QRB5165 455
>>> @@ -229,6 +232,9 @@
>>> #define QCOM_ID_SM8450_3 482
>>> #define QCOM_ID_SC7280 487
>>> #define QCOM_ID_SC7180P 495
>>> +#define QCOM_ID_IPQ5000 503
>>
>>> +#define QCOM_ID_IPQ0509 504
>>> +#define QCOM_ID_IPQ0518 505
>> Are you sure these names are in tact?
>
> Hi,
> They should be correct, I am seeing them being used downstream
> and in end products as well, IPQ0509 being one of those weird ones
> that integrate 256MB of RAM on the die as well.
Hmmm.. it's sketchy and weird-sounding, but also appealing in a way

I got caught off-guard with the leading zeroes, but probably qcom
just didn't want to mess with the IPQabcd scheme!

Konrad
>
> Regards,
> Robert
>
>>
>> Konrad
>>> #define QCOM_ID_SM6375 507
>>> #define QCOM_ID_IPQ9514 510
>>> #define QCOM_ID_IPQ9550 511
>>> @@ -236,6 +242,7 @@
>>> #define QCOM_ID_IPQ9570 513
>>> #define QCOM_ID_IPQ9574 514
>>> #define QCOM_ID_SM8550 519
>>> +#define QCOM_ID_IPQ5016 520
>>> #define QCOM_ID_IPQ9510 521
>>> #define QCOM_ID_QRB4210 523
>>> #define QCOM_ID_QRB2210 524
>>> @@ -243,6 +250,7 @@
>>> #define QCOM_ID_QRU1000 539
>>> #define QCOM_ID_QDU1000 545
>>> #define QCOM_ID_QDU1010 587
>>> +#define QCOM_ID_IPQ5019 569
>>> #define QCOM_ID_QRU1032 588
>>> #define QCOM_ID_QRU1052 589
>>> #define QCOM_ID_QRU1062 590

2023-05-02 17:38:53

by Robert Marko

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

On Tue, 2 May 2023 at 11:51, Konrad Dybcio <[email protected]> wrote:
>
>
>
> On 1.05.2023 23:22, Robert Marko wrote:
> > On Mon, 1 May 2023 at 14:51, Konrad Dybcio <[email protected]> wrote:
> >>
> >>
> >>
> >> On 29.04.2023 21:33, Robert Marko wrote:
> >>> Add SOC IDs for the IPQ5018 family.
> >>>
> >>> Signed-off-by: Robert Marko <[email protected]>
> >>> ---
> >>> include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
> >>> 1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> >>> index 802495b20276..c1283bad81e1 100644
> >>> --- a/include/dt-bindings/arm/qcom,ids.h
> >>> +++ b/include/dt-bindings/arm/qcom,ids.h
> >>> @@ -216,6 +216,9 @@
> >>> #define QCOM_ID_SM8350 439
> >>> #define QCOM_ID_QCM2290 441
> >>> #define QCOM_ID_SM6115 444
> >>> +#define QCOM_ID_IPQ5010 446
> >>> +#define QCOM_ID_IPQ5018 447
> >>> +#define QCOM_ID_IPQ5028 448
> >>> #define QCOM_ID_SC8280XP 449
> >>> #define QCOM_ID_IPQ6005 453
> >>> #define QCOM_ID_QRB5165 455
> >>> @@ -229,6 +232,9 @@
> >>> #define QCOM_ID_SM8450_3 482
> >>> #define QCOM_ID_SC7280 487
> >>> #define QCOM_ID_SC7180P 495
> >>> +#define QCOM_ID_IPQ5000 503
> >>
> >>> +#define QCOM_ID_IPQ0509 504
> >>> +#define QCOM_ID_IPQ0518 505
> >> Are you sure these names are in tact?
> >
> > Hi,
> > They should be correct, I am seeing them being used downstream
> > and in end products as well, IPQ0509 being one of those weird ones
> > that integrate 256MB of RAM on the die as well.
> Hmmm.. it's sketchy and weird-sounding, but also appealing in a way
>
> I got caught off-guard with the leading zeroes, but probably qcom
> just didn't want to mess with the IPQabcd scheme!

I would guess the same that they wanted to keep the naming scheme
intact, I also thought it was an error but then I found FCC images with
the IPQ0509 SoC being actually used.

Regards,
Robert
>
> Konrad
> >
> > Regards,
> > Robert
> >
> >>
> >> Konrad
> >>> #define QCOM_ID_SM6375 507
> >>> #define QCOM_ID_IPQ9514 510
> >>> #define QCOM_ID_IPQ9550 511
> >>> @@ -236,6 +242,7 @@
> >>> #define QCOM_ID_IPQ9570 513
> >>> #define QCOM_ID_IPQ9574 514
> >>> #define QCOM_ID_SM8550 519
> >>> +#define QCOM_ID_IPQ5016 520
> >>> #define QCOM_ID_IPQ9510 521
> >>> #define QCOM_ID_QRB4210 523
> >>> #define QCOM_ID_QRB2210 524
> >>> @@ -243,6 +250,7 @@
> >>> #define QCOM_ID_QRU1000 539
> >>> #define QCOM_ID_QDU1000 545
> >>> #define QCOM_ID_QDU1010 587
> >>> +#define QCOM_ID_IPQ5019 569
> >>> #define QCOM_ID_QRU1032 588
> >>> #define QCOM_ID_QRU1052 589
> >>> #define QCOM_ID_QRU1062 590

2023-05-25 05:42:23

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family

On Sat, 29 Apr 2023 21:33:35 +0200, Robert Marko wrote:
> Add SOC IDs for the IPQ5018 family.
>
>

Applied, thanks!

[1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018 family
commit: e5b03cd101bd3dbbc7cbbe4c6e55a37070386494
[2/2] soc: qcom: socinfo: Add IDs for IPQ5018 family
commit: 0369a5906e46a2431a8fe04aa79cba6583e53e73

Best regards,
--
Bjorn Andersson <[email protected]>