2016-11-08 09:17:19

by Zhi Zhang

Subject: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()

Fix printing wrong return variable for invalidate_inode_pages2_range
in ceph_direct_read_write().

Signed-off-by: Zhi Zhang <[email protected]>
---
fs/ceph/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 18630e8..0136195 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
pos >> PAGE_SHIFT,
(pos + count) >> PAGE_SHIFT);
if (ret2 < 0)
- dout("invalidate_inode_pages2_range returned
%d\n", ret);
+ dout("invalidate_inode_pages2_range returned
%d\n", ret2);

flags = CEPH_OSD_FLAG_ORDERSNAP |
CEPH_OSD_FLAG_ONDISK |


Regards,
Zhi Zhang (David)
Contact: [email protected]
[email protected]

2016-11-08 13:48:24

by Ilya Dryomov

Subject: Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()

On Tue, Nov 8, 2016 at 10:16 AM, Zhi Zhang <[email protected]> wrote:
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <[email protected]>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>

Applied.

(This is mangled, and had to be applied manually. Check out
Documentation/email-clients.txt in the kernel tree.)

Thanks,

Ilya

2016-11-08 14:21:38

by Yan, Zheng

Subject: Re: [PATCH] ceph: fix printing wrong return variable in ceph_direct_read_write()

> On 8 Nov 2016, at 17:16, Zhi Zhang <[email protected]> wrote:
>
> Fix printing wrong return variable for invalidate_inode_pages2_range
> in ceph_direct_read_write().
>
> Signed-off-by: Zhi Zhang <[email protected]>
> ---
> fs/ceph/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> index 18630e8..0136195 100644
> --- a/fs/ceph/file.c
> +++ b/fs/ceph/file.c
> @@ -906,7 +906,7 @@ void ceph_sync_write_wait(struct inode *inode)
> pos >> PAGE_SHIFT,
> (pos + count) >> PAGE_SHIFT);
> if (ret2 < 0)
> - dout("invalidate_inode_pages2_range returned
> %d\n", ret);
> + dout("invalidate_inode_pages2_range returned
> %d\n", ret2);
>
> flags = CEPH_OSD_FLAG_ORDERSNAP |
> CEPH_OSD_FLAG_ONDISK |
>
>

Applied, Thanks

Yan, Zheng

> Regards,
> Zhi Zhang (David)
> Contact: [email protected]
> [email protected]