2018-01-10 14:13:41

by Wei Yongjun

Subject: [PATCH -next] meson-mx-socinfo: Make local function meson_mx_socinfo_init() static

Fixes the following sparse warnings:

drivers/soc/amlogic/meson-mx-socinfo.c:107:12: warning:
symbol 'meson_mx_socinfo_init' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/soc/amlogic/meson-mx-socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c
index 7bfff5f..78f0f1a 100644
--- a/drivers/soc/amlogic/meson-mx-socinfo.c
+++ b/drivers/soc/amlogic/meson-mx-socinfo.c
@@ -104,7 +104,7 @@ static const char *meson_mx_socinfo_soc_id(unsigned int major_ver,
{ /* sentinel */ }
};

-int __init meson_mx_socinfo_init(void)
+static int __init meson_mx_socinfo_init(void)
{
struct soc_device_attribute *soc_dev_attr;
struct soc_device *soc_dev;

2018-02-09 00:50:18

by Kevin Hilman

Subject: Re: [PATCH -next] meson-mx-socinfo: Make local function meson_mx_socinfo_init() static

On Wed, Jan 10, 2018 at 6:19 AM, Wei Yongjun <[email protected]> wrote:
> Fixes the following sparse warnings:
>
> drivers/soc/amlogic/meson-mx-socinfo.c:107:12: warning:
> symbol 'meson_mx_socinfo_init' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied for v4.17,

Kevin