2022-02-14 18:45:49

by Yang Li

Subject: [PATCH -next v2] i2c: designware: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---

--Changes in v2:
According to Jan's suggestion
Fix the same problem in check_i2c_req_sts() function.

drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
index 752e0024db03..9d37becbd846 100644
--- a/drivers/i2c/busses/i2c-designware-amdpsp.c
+++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
@@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)
case PSP_I2C_REQ_STS_INV_PARAM:
default:
return -EIO;
- };
+ }
}

static int psp_send_check_i2c_req(struct psp_i2c_req *req)
@@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
if (psp_i2c_access_count) {
psp_i2c_access_count++;
goto cleanup;
- };
+ }

status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
if (status) {
--
2.20.1.7.g153144c

2022-02-14 20:13:04

by Jan Dąbroś

Subject: Re: [PATCH -next v2] i2c: designware: remove unneeded semicolon

pon., 14 lut 2022 o 10:00 Yang Li <[email protected]> napisał(a):
>
> Eliminate the following coccicheck warning:

nit: warnings

> ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Beside a nit above:
Reviewed-by: Jan Dabros <[email protected]>

Best Regards,
Jan

> ---
>
> --Changes in v2:
> According to Jan's suggestion
> Fix the same problem in check_i2c_req_sts() function.
>
> drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
> index 752e0024db03..9d37becbd846 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)
> case PSP_I2C_REQ_STS_INV_PARAM:
> default:
> return -EIO;
> - };
> + }
> }
>
> static int psp_send_check_i2c_req(struct psp_i2c_req *req)
> @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
> if (psp_i2c_access_count) {
> psp_i2c_access_count++;
> goto cleanup;
> - };
> + }
>
> status = psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
> if (status) {
> --
> 2.20.1.7.g153144c
>