2022-02-14 14:03:11

by Jarkko Nikula

[permalink] [raw]
Subject: Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon

Hi

On 2/14/22 14:47, Yang Li wrote:
> Eliminate the following coccicheck warnings:
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
>
> --Changes in v2:
> According to Jan's suggestion
> Fix the same problem in check_i2c_req_sts() function.
>
> drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
For future contributions: Technically this would be v3 rather than v2
RESEND since you fixed the typo in commit log noted by Jan for v2.

Please use RESEND only if you'll send exactly the same version for
instance if you didn't receive any comments for several weeks or some
recipient was missing from Cc field.

I believe Jan will give Reviewed-by tag to this version too.

Acked-by: Jarkko Nikula <[email protected]>


2022-02-14 20:39:49

by Jan Dąbroś

[permalink] [raw]
Subject: Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon

pon., 14 lut 2022 o 14:03 Jarkko Nikula
<[email protected]> napisał(a):
>
> Hi
>
> On 2/14/22 14:47, Yang Li wrote:
> > Eliminate the following coccicheck warnings:
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
> > ---
> >
> > --Changes in v2:
> > According to Jan's suggestion
> > Fix the same problem in check_i2c_req_sts() function.
> >
> > drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> For future contributions: Technically this would be v3 rather than v2
> RESEND since you fixed the typo in commit log noted by Jan for v2.
>
> Please use RESEND only if you'll send exactly the same version for
> instance if you didn't receive any comments for several weeks or some
> recipient was missing from Cc field.
>
> I believe Jan will give Reviewed-by tag to this version too.
>
> Acked-by: Jarkko Nikula <[email protected]>

Correct.
Reviewed-by: Jan Dabros <[email protected]>

Best Regards,
Jan