2024-06-02 00:05:43

by Dr. David Alan Gilbert

Subject: [PATCH] perf genelf: remove unused struct 'options'

From: "Dr. David Alan Gilbert" <[email protected]>

'options' has been unused since
commit fa7f7e735495 ("perf jit: Move test functionality in to a test").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
tools/perf/util/genelf.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
index ac17a3cb59dc..c8f6bee1fa61 100644
--- a/tools/perf/util/genelf.c
+++ b/tools/perf/util/genelf.c
@@ -54,11 +54,6 @@ typedef struct {
char name[0]; /* Start of the name+desc data */
} Elf_Note;

-struct options {
- char *output;
- int fd;
-};
-
static char shd_string_table[] = {
0,
'.', 't', 'e', 'x', 't', 0, /* 1 */
--
2.45.1

2024-06-03 16:33:57

by Ian Rogers

Subject: Re: [PATCH] perf genelf: remove unused struct 'options'

On Sat, Jun 1, 2024 at 5:05 PM <[email protected]> wrote:
>
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Hi/thanks David,

Reviewed-by: Ian Rogers <[email protected]>

Ian

> ---
> tools/perf/util/genelf.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/util/genelf.c b/tools/perf/util/genelf.c
> index ac17a3cb59dc..c8f6bee1fa61 100644
> --- a/tools/perf/util/genelf.c
> +++ b/tools/perf/util/genelf.c
> @@ -54,11 +54,6 @@ typedef struct {
> char name[0]; /* Start of the name+desc data */
> } Elf_Note;
>
> -struct options {
> - char *output;
> - int fd;
> -};
> -
> static char shd_string_table[] = {
> 0,
> '.', 't', 'e', 'x', 't', 0, /* 1 */
> --
> 2.45.1
>

2024-06-04 22:18:24

by Namhyung Kim

Subject: Re: [PATCH] perf genelf: remove unused struct 'options'

On Sun, 2 Jun 2024 01:05:05 +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'options' has been unused since
> commit fa7f7e735495 ("perf jit: Move test functionality in to a test").
>
> Remove it.
>
> [...]

Applied to perf-tools-next, thanks!

Best regards,
--
Namhyung Kim <[email protected]>