2023-06-14 03:48:31

by baomingtong001

Subject: [PATCH] perf bench: remove unneeded variable

fix the following coccicheck warning:

tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err".
Return "0".

Signed-off-by: Mingtong Bao <[email protected]>
---
tools/perf/bench/find-bit-bench.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/bench/find-bit-bench.c
b/tools/perf/bench/find-bit-bench.c
index 7e25b0e413f6..70619bc73841 100644
--- a/tools/perf/bench/find-bit-bench.c
+++ b/tools/perf/bench/find-bit-bench.c
@@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int
num_bits)

int bench_mem_find_bit(int argc, const char **argv)
{
- int err = 0, i;
+ int i;

argc = parse_options(argc, argv, options, bench_usage, 0);
if (argc) {
@@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
for (i = 1; i <= 2048; i <<= 1)
do_for_each_set_bit(i);

- return err;
+ return 0;
}

2023-06-14 05:14:50

by Ian Rogers

Subject: Re: [PATCH] perf bench: remove unneeded variable

On Tue, Jun 13, 2023 at 8:38 PM <[email protected]> wrote:
>
> fix the following coccicheck warning:
>
> tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err".
> Return "0".
>
> Signed-off-by: Mingtong Bao <[email protected]>

Reviewed-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> tools/perf/bench/find-bit-bench.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/find-bit-bench.c
> b/tools/perf/bench/find-bit-bench.c
> index 7e25b0e413f6..70619bc73841 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int
> num_bits)
>
> int bench_mem_find_bit(int argc, const char **argv)
> {
> - int err = 0, i;
> + int i;
>
> argc = parse_options(argc, argv, options, bench_usage, 0);
> if (argc) {
> @@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
> for (i = 1; i <= 2048; i <<= 1)
> do_for_each_set_bit(i);
>
> - return err;
> + return 0;
> }

2023-06-14 14:26:00

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf bench: remove unneeded variable

Em Wed, Jun 14, 2023 at 11:38:41AM +0800, [email protected] escreveu:
> fix the following coccicheck warning:
>
> tools/perf/bench/find-bit-bench.c:127:5-8: Unneeded variable: "err". Return
> "0".

⬢[acme@toolbox perf-tools-next]$ patch -p1 < ~/wb/1.patch
patching file tools/perf/bench/find-bit-bench.c
patch: **** malformed patch at line 117: num_bits)

⬢[acme@toolbox perf-tools-next]$

Please check the process you're following to generate and send the
patch.

There is a doc file for that...

Documentation/process/submitting-patches.rst

Well, two:

Documentation/process/submit-checklist.rst

I'm applying this manually,

Thanks,

- Arnaldo

> Signed-off-by: Mingtong Bao <[email protected]>
> ---
> tools/perf/bench/find-bit-bench.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/bench/find-bit-bench.c
> b/tools/perf/bench/find-bit-bench.c
> index 7e25b0e413f6..70619bc73841 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -124,7 +124,7 @@ static int do_for_each_set_bit(unsigned int num_bits)
>
> int bench_mem_find_bit(int argc, const char **argv)
> {
> - int err = 0, i;
> + int i;
>
> argc = parse_options(argc, argv, options, bench_usage, 0);
> if (argc) {
> @@ -135,5 +135,5 @@ int bench_mem_find_bit(int argc, const char **argv)
> for (i = 1; i <= 2048; i <<= 1)
> do_for_each_set_bit(i);
>
> - return err;
> + return 0;
> }

--

- Arnaldo