2020-09-08 06:37:22

by Grant Grundler

[permalink] [raw]
Subject: Apply from 2018? [V2,0/3] phy: qcom-ipq4019-usb: add new driver

Alban, Andy,
Can you please apply this patch series from 2018 or please explain
what I (or John) have to do so this series can be applied?

https://patchwork.kernel.org/cover/10552139/
[V2,0/3] phy: qcom-ipq4019-usb: add new driver

OpenWRT has been applying this code to all ipq4019 targets since Jul 2018:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=95672e04335ea0d7d8f468cec8f63d593cc6ede6

I expect if there were problems with it, we'd know by now.

$ find -name \*qcom-ipq4019-usb\*
./target/linux/ipq40xx/patches-5.4/076-phy-qcom-ipq4019-usb-add-driver-for-QCOM-IPQ4019.patch
./target/linux/ipq40xx/patches-5.4/075-dt-bindings-phy-qcom-ipq4019-usb-add-binding-documen.patch
./target/linux/ipq40xx/patches-4.19/076-phy-qcom-ipq4019-usb-add-driver-for-QCOM-IPQ4019.patch
./target/linux/ipq40xx/patches-4.19/075-dt-bindings-phy-qcom-ipq4019-usb-add-binding-documen.patch
...

In 2018, Rob Herring reviewed (and approved):
[V2,1/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document

I've just reviewed 2/3 and 3/3. You can add to those:
Reviewed-by: Grant Grundler <[email protected]>

I compared 3/3 with the DTS entries that were submitted (and I
approved) to chromeos-3.18 kernel tree in 2016:
https://chromium-review.googlesource.com/337605
https://chromium-review.googlesource.com/344471

While not identical, the important bits (reg values) are.

(I would reply to the original thread but I don't have it in a format
I can easily reply to.)

cheers,
grant


2020-09-08 06:43:21

by Grant Grundler

[permalink] [raw]
Subject: Re: Apply from 2018? [V2,0/3] phy: qcom-ipq4019-usb: add new driver

Adding [email protected] since Andy's email in MAINTAINERs bounced.
Using Matthew's personal email since his codeaurora email bounced.

On Mon, Sep 7, 2020 at 11:35 PM Grant Grundler <[email protected]> wrote:
>
> Alban, Andy,
> Can you please apply this patch series from 2018 or please explain
> what I (or John) have to do so this series can be applied?
>
> https://patchwork.kernel.org/cover/10552139/
> [V2,0/3] phy: qcom-ipq4019-usb: add new driver
>
> OpenWRT has been applying this code to all ipq4019 targets since Jul 2018:
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=95672e04335ea0d7d8f468cec8f63d593cc6ede6
>
> I expect if there were problems with it, we'd know by now.
>
> $ find -name \*qcom-ipq4019-usb\*
> ./target/linux/ipq40xx/patches-5.4/076-phy-qcom-ipq4019-usb-add-driver-for-QCOM-IPQ4019.patch
> ./target/linux/ipq40xx/patches-5.4/075-dt-bindings-phy-qcom-ipq4019-usb-add-binding-documen.patch
> ./target/linux/ipq40xx/patches-4.19/076-phy-qcom-ipq4019-usb-add-driver-for-QCOM-IPQ4019.patch
> ./target/linux/ipq40xx/patches-4.19/075-dt-bindings-phy-qcom-ipq4019-usb-add-binding-documen.patch
> ...
>
> In 2018, Rob Herring reviewed (and approved):
> [V2,1/3] dt-bindings: phy-qcom-ipq4019-usb: add binding document
>
> I've just reviewed 2/3 and 3/3. You can add to those:
> Reviewed-by: Grant Grundler <[email protected]>
>
> I compared 3/3 with the DTS entries that were submitted (and I
> approved) to chromeos-3.18 kernel tree in 2016:
> https://chromium-review.googlesource.com/337605
> https://chromium-review.googlesource.com/344471
>
> While not identical, the important bits (reg values) are.
>
> (I would reply to the original thread but I don't have it in a format
> I can easily reply to.)
>
> cheers,
> grant