CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic. This is done in preparation to making
further changes to this defconfig cleaner.
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
---
Changes in v2:
- rework commit log (Fabio Estevam)
arch/arm/configs/imx_v6_v7_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index aa02d18f44d1..0c887a059df3 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y
CONFIG_PROVE_LOCKING=y
# CONFIG_DEBUG_BUGVERBOSE is not set
# CONFIG_FTRACE is not set
-# CONFIG_ARM_UNWIND is not set
--
2.19.1
From: Andreas Müller <[email protected]>
This is very helpful debugging USB issues.
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
---
Changes in v2: None
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 22ad2d7a1cf2..d339913845fa 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y
CONFIG_SND_SIMPLE_CARD=y
CONFIG_HID_MULTITOUCH=y
CONFIG_USB=y
+CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_MXC=y
CONFIG_USB_STORAGE=y
--
2.19.1
From: Andreas Müller <[email protected]>
This is necessary to support network over bluetooth:
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
---
Changes in v2: None
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0c887a059df3..22ad2d7a1cf2 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -81,6 +81,7 @@ CONFIG_NETFILTER=y
CONFIG_CAN=y
CONFIG_CAN_FLEXCAN=y
CONFIG_BT=y
+CONFIG_BT_BNEP=m
CONFIG_BT_HCIUART=y
CONFIG_BT_HCIUART_LL=y
CONFIG_CFG80211=y
--
2.19.1
On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
<[email protected]> wrote:
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> selected by the Kconfig logic. This is done in preparation to making
> further changes to this defconfig cleaner.
>
Does this mean we no longer get the unwinder, or there is some other
config (which?) that unconditionally selects it?
Arnd
On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <[email protected]> wrote:
> On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> <[email protected]> wrote:
> >
> > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > selected by the Kconfig logic. This is done in preparation to making
> > further changes to this defconfig cleaner.
> >
>
> Does this mean we no longer get the unwinder, or there is some other
> config (which?) that unconditionally selects it?
It is selected. Before changing the defconfig I did a savedefconfig to
avoid unrelated changes to be included on the subsequent patches and
then I found it was now selected.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador
<[email protected]> wrote:
>
> On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <[email protected]> wrote:
> > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> > <[email protected]> wrote:
> > >
> > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > > selected by the Kconfig logic. This is done in preparation to making
> > > further changes to this defconfig cleaner.
> > >
> >
> > Does this mean we no longer get the unwinder, or there is some other
> > config (which?) that unconditionally selects it?
>
> It is selected. Before changing the defconfig I did a savedefconfig to
> avoid unrelated changes to be included on the subsequent patches and
> then I found it was now selected.
Ok, then please mention in the changelog which other option selects it,
as I said.
Aside from that, your series looks fine to me.
Arnd
Hello Arnd,
On Sun, Nov 25, 2018 at 7:48 PM Arnd Bergmann <[email protected]> wrote:
> On Sun, Nov 25, 2018 at 10:45 PM Otavio Salvador
> <[email protected]> wrote:
> >
> > On Sun, Nov 25, 2018 at 7:35 PM Arnd Bergmann <[email protected]> wrote:
> > > On Sun, Nov 25, 2018 at 10:24 PM Otavio Salvador
> > > <[email protected]> wrote:
> > > >
> > > > CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> > > > selected by the Kconfig logic. This is done in preparation to making
> > > > further changes to this defconfig cleaner.
> > > >
> > >
> > > Does this mean we no longer get the unwinder, or there is some other
> > > config (which?) that unconditionally selects it?
> >
> > It is selected. Before changing the defconfig I did a savedefconfig to
> > avoid unrelated changes to be included on the subsequent patches and
> > then I found it was now selected.
>
> Ok, then please mention in the changelog which other option selects it,
> as I said.
>
> Aside from that, your series looks fine to me.
Thank you for reviewing it. I sent a v3 mentioning it.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750