2021-06-03 14:01:41

by Yu Kuai

Subject: [PATCH] kasan: fix doc warning in init.c

Fix gcc W=1 warning:

mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'

Signed-off-by: Yu Kuai <[email protected]>
---
mm/kasan/init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/kasan/init.c b/mm/kasan/init.c
index c4605ac9837b..348f31d15a97 100644
--- a/mm/kasan/init.c
+++ b/mm/kasan/init.c
@@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
/**
* kasan_populate_early_shadow - populate shadow memory region with
* kasan_early_shadow_page
- * @shadow_start - start of the memory range to populate
- * @shadow_end - end of the memory range to populate
+ * @shadow_start: start of the memory range to populate
+ * @shadow_end: end of the memory range to populate
*/
int __ref kasan_populate_early_shadow(const void *shadow_start,
const void *shadow_end)
--
2.31.1

2021-06-03 14:19:32

by Andrey Ryabinin

Subject: Re: [PATCH] kasan: fix doc warning in init.c

On Thu, Jun 3, 2021 at 4:57 PM Yu Kuai <[email protected]> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <[email protected]>

Acked-by: Andrey Ryabinin <[email protected]>

2021-06-05 20:20:56

by Andrey Konovalov

Subject: Re: [PATCH] kasan: fix doc warning in init.c

On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <[email protected]> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <[email protected]>
> ---
> mm/kasan/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
> /**
> * kasan_populate_early_shadow - populate shadow memory region with
> * kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
> */
> int __ref kasan_populate_early_shadow(const void *shadow_start,
> const void *shadow_end)
> --
> 2.31.1

Reviewed-by: Andrey Konovalov <[email protected]>