2020-06-22 11:20:10

by Vaibhav Gupta

[permalink] [raw]
Subject: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

Linux Kernel Mentee: Remove Legacy Power Management.

The purpose of this patch series is to remove legacy power management callbacks
from amd ethernet drivers.

The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling the power management
themselves, which is not recommended.

The conversion requires the removal of the those function calls and change the
callback definition accordingly and make use of dev_pm_ops structure.

All patches are compile-tested only.

Vaibhav Gupta (3):
pcnet32: Convert to generic power management
amd8111e: Convert to generic power management
amd-xgbe: Convert to generic power management

drivers/net/ethernet/amd/amd8111e.c | 30 +++++++++---------------
drivers/net/ethernet/amd/pcnet32.c | 22 ++++++++---------
drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 19 +++++++--------
3 files changed, 31 insertions(+), 40 deletions(-)

--
2.27.0


2020-06-24 03:32:14

by David Miller

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

From: Vaibhav Gupta <[email protected]>
Date: Mon, 22 Jun 2020 16:43:57 +0530

> Linux Kernel Mentee: Remove Legacy Power Management.
>
> The purpose of this patch series is to remove legacy power management callbacks
> from amd ethernet drivers.
>
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the power management
> themselves, which is not recommended.
>
> The conversion requires the removal of the those function calls and change the
> callback definition accordingly and make use of dev_pm_ops structure.
>
> All patches are compile-tested only.

Series applied, thanks.

2020-06-24 16:35:44

by Vaibhav Gupta

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

On Wed, 24 Jun 2020 at 09:01, David Miller <[email protected]> wrote:
>
> From: Vaibhav Gupta <[email protected]>
> Date: Mon, 22 Jun 2020 16:43:57 +0530
>
> > Linux Kernel Mentee: Remove Legacy Power Management.
> >
> > The purpose of this patch series is to remove legacy power management callbacks
> > from amd ethernet drivers.
> >
> > The callbacks performing suspend() and resume() operations are still calling
> > pci_save_state(), pci_set_power_state(), etc. and handling the power management
> > themselves, which is not recommended.
> >
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly and make use of dev_pm_ops structure.
> >
> > All patches are compile-tested only.
>
> Series applied
Thank You !
-- Vaibhav Gupta
> , thanks.