Signed-off-by: Nick <[email protected]>
---
drivers/clk/sunxi/clk-sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
u32 rate;
if (of_property_read_u32(node, "clock-frequency", &rate))
+ kree(gate);
return;
/* allocate fixed-rate and gate clock structs */
--
1.9.1
On 06/14/2014 10:11 PM, Nick wrote:
> Signed-off-by: Nick <[email protected]>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
'gate' is not allocated at this point either... at least not in Linus' tree.
> return;
And you forgot {} around these 2 statements.
WBR, Sergei
On 14/06/14 19:11, Nick wrote:
> Signed-off-by: Nick <[email protected]>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
> return;
There are no braces around this so the function of this code as written
is an unconditional return and the return shouldn't be indented. I
suspect, without reading the rest of the file, that that isn't what you
intended.
>
> /* allocate fixed-rate and gate clock structs */
>
Adam
On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
> Signed-off-by: Nick <[email protected]>
This should be your full real name here.
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kree(gate);
There's a typo in kfree. How does that even compile?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
New Patch Just Fixed Typo for my email client.
Signed-off-by: Nick <[email protected]>
---
drivers/clk/sunxi/clk-sunxi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi/clk-sunxi.
c b/drivers/clk/sunxi/clk-sunxi.c
index 4264834..6f4fc51 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
device_node *node)
u32 rate;
if (of_property_read_u32(node, "clock-frequency", &rate))
+ kfree(gate);
return;
/* allocate fixed-rate and gate clock structs */
Cheers Nick
On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
<[email protected]> wrote:
> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>> Signed-off-by: Nick <[email protected]>
>
> This should be your full real name here.
>
>> ---
>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>> index 4264834..6f4fc51 100644
>> --- a/drivers/clk/sunxi/clk-sunxi.c
>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>> u32 rate;
>>
>> if (of_property_read_u32(node, "clock-frequency", &rate))
>> + kree(gate);
>
> There's a typo in kfree. How does that even compile?
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Seems the bug is fixed , don't worry about resent patch.
Thanks Nick
On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <[email protected]> wrote:
> New Patch Just Fixed Typo for my email client.
> Signed-off-by: Nick <[email protected]>
> ---
> drivers/clk/sunxi/clk-sunxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.
> c b/drivers/clk/sunxi/clk-sunxi.c
> index 4264834..6f4fc51 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> device_node *node)
> u32 rate;
>
> if (of_property_read_u32(node, "clock-frequency", &rate))
> + kfree(gate);
> return;
>
> /* allocate fixed-rate and gate clock structs */
> Cheers Nick
>
> On Sun, Jun 15, 2014 at 4:30 PM, Maxime Ripard
> <[email protected]> wrote:
>> On Sat, Jun 14, 2014 at 02:11:48PM -0400, Nick wrote:
>>> Signed-off-by: Nick <[email protected]>
>>
>> This should be your full real name here.
>>
>>> ---
>>> drivers/clk/sunxi/clk-sunxi.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
>>> index 4264834..6f4fc51 100644
>>> --- a/drivers/clk/sunxi/clk-sunxi.c
>>> +++ b/drivers/clk/sunxi/clk-sunxi.c
>>> @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct device_node *node)
>>> u32 rate;
>>>
>>> if (of_property_read_u32(node, "clock-frequency", &rate))
>>> + kree(gate);
>>
>> There's a typo in kfree. How does that even compile?
>>
>> --
>> Maxime Ripard, Free Electrons
>> Embedded Linux, Kernel and Android engineering
>> http://free-electrons.com
On Sun, Jun 15, 2014 at 11:31:41PM -0400, Nick Krause wrote:
> Seems the bug is fixed , don't worry about resent patch.
> Thanks Nick
>
> On Sun, Jun 15, 2014 at 11:21 PM, Nick Krause <[email protected]> wrote:
> > @@ -42,6 +42,7 @@ static void __init sun4i_osc_clk_setup(struct
> > device_node *node)
> > u32 rate;
> >
> > if (of_property_read_u32(node, "clock-frequency", &rate))
> > + kfree(gate);
> > return;
In any case, the kernel is not coded in Python.
C uses braces { } to enclose blocks of code, and does not care about
indentation - indentation is meaningless to C. Python purely identifies
blocks of code by indentation alone.
Please take account of the programming language when creating patches.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.