2019-01-23 12:07:14

by Chaotian Jing

Subject: [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay

to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
register.

Signed-off-by: Chaotian Jing <[email protected]>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 8afeaf8..833ef05 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)

if (timing == MMC_TIMING_MMC_HS400 &&
host->dev_comp->hs400_tune)
- sdr_set_field(host->base + PAD_CMD_TUNE,
+ sdr_set_field(host->base + tune_reg,
MSDC_PAD_TUNE_CMDRRDLY,
host->hs400_cmd_int_delay);
dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
--
1.8.1.1.dirty

2019-01-28 12:06:10

by Ulf Hansson

Subject: Re: [PATCH] mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay

On Wed, 23 Jan 2019 at 13:05, Chaotian Jing <[email protected]> wrote:
>
> to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
> register.
>
> Signed-off-by: Chaotian Jing <[email protected]>

Applied for fixes, adding a fixes+stable tag, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/mtk-sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 8afeaf8..833ef05 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
>
> if (timing == MMC_TIMING_MMC_HS400 &&
> host->dev_comp->hs400_tune)
> - sdr_set_field(host->base + PAD_CMD_TUNE,
> + sdr_set_field(host->base + tune_reg,
> MSDC_PAD_TUNE_CMDRRDLY,
> host->hs400_cmd_int_delay);
> dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
> --
> 1.8.1.1.dirty
>