2016-03-11 16:44:00

by Shawn Lin

Subject: [PATCH] mmc: core: remove redundant memset of mmc_decode_cid

When initializing sd or sdio card, we get struct mmc_card
from mmc_alloc_card which allocates it by kzalloc. So we don't
need another memset while decoding cid.

Signed-off-by: Shawn Lin <[email protected]>
---

drivers/mmc/core/sd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index bb39a29..b95bd24 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -74,8 +74,6 @@ void mmc_decode_cid(struct mmc_card *card)
{
u32 *resp = card->raw_cid;

- memset(&card->cid, 0, sizeof(struct mmc_cid));
-
/*
* SD doesn't currently have a version field so we will
* have to assume we can parse this.
--
2.3.7

2016-03-16 11:38:18

by Ulf Hansson

Subject: Re: [PATCH] mmc: core: remove redundant memset of mmc_decode_cid

On 11 March 2016 at 17:35, Shawn Lin <[email protected]> wrote:
> When initializing sd or sdio card, we get struct mmc_card
> from mmc_alloc_card which allocates it by kzalloc. So we don't
> need another memset while decoding cid.
>
> Signed-off-by: Shawn Lin <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
> drivers/mmc/core/sd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index bb39a29..b95bd24 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -74,8 +74,6 @@ void mmc_decode_cid(struct mmc_card *card)
> {
> u32 *resp = card->raw_cid;
>
> - memset(&card->cid, 0, sizeof(struct mmc_cid));
> -
> /*
> * SD doesn't currently have a version field so we will
> * have to assume we can parse this.
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html