2016-03-14 04:43:18

by Shawn Lin

Subject: [PATCH] mmc: core: remove redundant memset of sdio_read_cccr

When initializing sdio card, we get struct mmc_card
from mmc_alloc_card which allocates it by kzalloc. So we
don't need another memset while reading cccr.

Signed-off-by: Shawn Lin <[email protected]>
---

drivers/mmc/core/sdio.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 467b3cf..bd44ba8 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -106,8 +106,6 @@ static int sdio_read_cccr(struct mmc_card *card, u32 ocr)
unsigned char data;
unsigned char speed;

- memset(&card->cccr, 0, sizeof(struct sdio_cccr));
-
ret = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_CCCR, 0, &data);
if (ret)
goto out;
--
2.3.7

2016-03-16 11:38:26

by Ulf Hansson

Subject: Re: [PATCH] mmc: core: remove redundant memset of sdio_read_cccr

On 14 March 2016 at 05:41, Shawn Lin <[email protected]> wrote:
> When initializing sdio card, we get struct mmc_card
> from mmc_alloc_card which allocates it by kzalloc. So we
> don't need another memset while reading cccr.
>
> Signed-off-by: Shawn Lin <[email protected]>

Thanks, applied for next!

Kind regards
Uffe


> ---
>
> drivers/mmc/core/sdio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index 467b3cf..bd44ba8 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -106,8 +106,6 @@ static int sdio_read_cccr(struct mmc_card *card, u32 ocr)
> unsigned char data;
> unsigned char speed;
>
> - memset(&card->cccr, 0, sizeof(struct sdio_cccr));
> -
> ret = mmc_io_rw_direct(card, 0, 0, SDIO_CCCR_CCCR, 0, &data);
> if (ret)
> goto out;
> --
> 2.3.7
>
>