On Tue, 29 Aug 2023 at 09:18, Linus Walleij <[email protected]> wrote:
>
> On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
> <[email protected]> wrote:
>
> > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> > checking if the device is compatible with atmel,hsmci. Instead handle it in
> > the if() condition. The compiler optimizes out the entire if() clause if
> > the first expression in the if() clause is constant false.
> >
> > Signed-off-by: Balamanikandan Gunasundar <[email protected]>
> > Suggested-by: Linus Walleij <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> Thanks for tidying this up Balamanikandan!
Linus, we didn't manage to get this into v6.6. So, it's probably
better if you pick up this via your tree for v6.7.
Note that the commit message header may be a bit misleading, as this
is really a gpio patch. Maybe you can amend that when applying?
Kind regards
Uffe
On Thu, Sep 14, 2023 at 2:16 PM Ulf Hansson <[email protected]> wrote:
> On Tue, 29 Aug 2023 at 09:18, Linus Walleij <[email protected]> wrote:
> >
> > On Mon, Aug 28, 2023 at 12:04 PM Balamanikandan Gunasundar
> > <[email protected]> wrote:
> >
> > > Remove the preprocessor directive IS_ENABLED(CONFIG_MMC_ATMELMCI) while
> > > checking if the device is compatible with atmel,hsmci. Instead handle it in
> > > the if() condition. The compiler optimizes out the entire if() clause if
> > > the first expression in the if() clause is constant false.
> > >
> > > Signed-off-by: Balamanikandan Gunasundar <[email protected]>
> > > Suggested-by: Linus Walleij <[email protected]>
> >
> > Reviewed-by: Linus Walleij <[email protected]>
> >
> > Thanks for tidying this up Balamanikandan!
>
> Linus, we didn't manage to get this into v6.6. So, it's probably
> better if you pick up this via your tree for v6.7.
Oh it's actually Bartosz managing the GPIO tree these days.
(Which I am very happy about!)
The best is to resend the patch to the GPIO maintainers and
linux-gpio@vger.
Yours,
Linus Walleij