2017-03-10 03:22:47

by Jisheng Zhang

Subject: [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, so its
users doesn't need to set the drvdata again. These patches clean up all
unnecessary platform_set_drvdata() call.

Jisheng Zhang (3):
mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call
mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call
mmc: sdhci-st: remove unnecessary platform_set_drvdata() call

drivers/mmc/host/sdhci-pxav2.c | 2 --
drivers/mmc/host/sdhci-pxav3.c | 2 --
drivers/mmc/host/sdhci-st.c | 2 --
3 files changed, 6 deletions(-)

--
2.11.0

2017-03-10 03:22:49

by Jisheng Zhang

Subject: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.

Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/mmc/host/sdhci-st.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index ed92ce729dde..7fff6490855c 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
goto err_out;
}

- platform_set_drvdata(pdev, host);
-
host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION));

dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n",
--
2.11.0

2017-03-10 03:23:03

by Jisheng Zhang

Subject: [PATCH 2/3] mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.

Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/mmc/host/sdhci-pxav2.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2.c
index 347eae2d7b6a..74e21ad699e0 100644
--- a/drivers/mmc/host/sdhci-pxav2.c
+++ b/drivers/mmc/host/sdhci-pxav2.c
@@ -222,8 +222,6 @@ static int sdhci_pxav2_probe(struct platform_device *pdev)
goto err_add_host;
}

- platform_set_drvdata(pdev, host);
-
return 0;

err_add_host:
--
2.11.0

2017-03-10 03:22:46

by Jisheng Zhang

Subject: [PATCH 1/3] mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove
the unnecessary platform_set_drvdata() call.

Signed-off-by: Jisheng Zhang <[email protected]>
---
drivers/mmc/host/sdhci-pxav3.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index d0f5c05fbc19..132670a612a0 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -480,8 +480,6 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
goto err_add_host;
}

- platform_set_drvdata(pdev, host);
-
if (host->mmc->pm_caps & MMC_PM_WAKE_SDIO_IRQ)
device_init_wakeup(&pdev->dev, 1);

--
2.11.0

2017-03-10 08:40:53

by Patrice CHOTARD

Subject: Re: [PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call

Hi Jisheng

On 03/10/2017 04:17 AM, Jisheng Zhang wrote:
> sdhci_pltfm_init() has already set the platform drvdata for us, remove
> the unnecessary platform_set_drvdata() call.
>
> Signed-off-by: Jisheng Zhang <[email protected]>
> ---
> drivers/mmc/host/sdhci-st.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index ed92ce729dde..7fff6490855c 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -418,8 +418,6 @@ static int sdhci_st_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - platform_set_drvdata(pdev, host);
> -
> host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION));
>
> dev_info(&pdev->dev, "SDHCI ST Initialised: Host Version: 0x%x Vendor Version 0x%x\n",
>

Acked-by: Patrice Chotard <[email protected]>

Thanks

2017-03-16 14:46:40

by Ulf Hansson

Subject: Re: [PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call

On 10 March 2017 at 04:17, Jisheng Zhang <[email protected]> wrote:
> sdhci_pltfm_init() has already set the platform drvdata for us, so its
> users doesn't need to set the drvdata again. These patches clean up all
> unnecessary platform_set_drvdata() call.
>
> Jisheng Zhang (3):
> mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call
> mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call
> mmc: sdhci-st: remove unnecessary platform_set_drvdata() call
>
> drivers/mmc/host/sdhci-pxav2.c | 2 --
> drivers/mmc/host/sdhci-pxav3.c | 2 --
> drivers/mmc/host/sdhci-st.c | 2 --
> 3 files changed, 6 deletions(-)
>
> --
> 2.11.0
>

Thanks, applied for next!

Kind regards
Uffe