2023-10-19 10:07:13

by André Draszik

Subject: [PATCH 1/2] tty: serial: samsung: drop earlycon support for unsupported platforms

Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed
support here for several old platforms, but kept support for earlycon
for those same platforms.

As earlycon support for otherwise unsupported platforms doesn't seem to
be useful, just drop it as well.

Suggested-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: André Draszik <[email protected]>
---
drivers/tty/serial/samsung_tty.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 6b8d4b4402e9..a74ecc78f4e0 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = {
.rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK,
};

-static int __init s3c2410_early_console_setup(struct earlycon_device *device,
- const char *opt)
-{
- device->port.private_data = &s3c2410_early_console_data;
- return samsung_early_console_setup(device, opt);
-}
-
-OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart",
- s3c2410_early_console_setup);
-
-/* S3C2412, S3C2440, S3C64xx */
+/* S3C64xx */
static struct samsung_early_console_data s3c2440_early_console_data = {
.txfull_mask = S3C2440_UFSTAT_TXFULL,
.rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK,
@@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device,
return samsung_early_console_setup(device, opt);
}

-OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart",
- s3c2440_early_console_setup);
-OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart",
- s3c2440_early_console_setup);
OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart",
s3c2440_early_console_setup);

--
2.40.1

2023-10-19 10:07:15

by André Draszik

Subject: [PATCH 2/2] dt-bindings: serial: drop unsupported samsung bindings

Now that no implementation exists anymore for
samsung,s3c24(1[02]|40)-uart, remove those bindings from here as well.

Signed-off-by: André Draszik <[email protected]>
---
Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 ----
1 file changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
index 8bd88d5cbb11..d45079ef7bd9 100644
--- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
+++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
@@ -24,9 +24,6 @@ properties:
- enum:
- apple,s5l-uart
- axis,artpec8-uart
- - samsung,s3c2410-uart
- - samsung,s3c2412-uart
- - samsung,s3c2440-uart
- samsung,s3c6400-uart
- samsung,s5pv210-uart
- samsung,exynos4210-uart
@@ -96,7 +93,6 @@ allOf:
compatible:
contains:
enum:
- - samsung,s3c2410-uart
- samsung,s5pv210-uart
then:
properties:
--
2.40.1

2023-10-19 12:41:26

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] tty: serial: samsung: drop earlycon support for unsupported platforms

On 19/10/2023 12:06, André Draszik wrote:
> Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed
> support here for several old platforms, but kept support for earlycon
> for those same platforms.
>
> As earlycon support for otherwise unsupported platforms doesn't seem to
> be useful, just drop it as well.
>
> Suggested-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: André Draszik <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-10-19 12:41:56

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] dt-bindings: serial: drop unsupported samsung bindings

On 19/10/2023 12:06, André Draszik wrote:
> Now that no implementation exists anymore for
> samsung,s3c24(1[02]|40)-uart, remove those bindings from here as well.
>
> Signed-off-by: André Draszik <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-10-19 14:33:07

by Sam Protsenko

Subject: Re: [PATCH 1/2] tty: serial: samsung: drop earlycon support for unsupported platforms

On Thu, Oct 19, 2023 at 5:06 AM André Draszik <[email protected]> wrote:
>
> Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") removed
> support here for several old platforms, but kept support for earlycon
> for those same platforms.
>
> As earlycon support for otherwise unsupported platforms doesn't seem to
> be useful, just drop it as well.
>
> Suggested-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: André Draszik <[email protected]>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> drivers/tty/serial/samsung_tty.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 6b8d4b4402e9..a74ecc78f4e0 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2735,17 +2735,7 @@ static struct samsung_early_console_data s3c2410_early_console_data = {
> .rxfifo_mask = S3C2410_UFSTAT_RXFULL | S3C2410_UFSTAT_RXMASK,
> };
>
> -static int __init s3c2410_early_console_setup(struct earlycon_device *device,
> - const char *opt)
> -{
> - device->port.private_data = &s3c2410_early_console_data;
> - return samsung_early_console_setup(device, opt);
> -}
> -
> -OF_EARLYCON_DECLARE(s3c2410, "samsung,s3c2410-uart",
> - s3c2410_early_console_setup);
> -
> -/* S3C2412, S3C2440, S3C64xx */
> +/* S3C64xx */
> static struct samsung_early_console_data s3c2440_early_console_data = {
> .txfull_mask = S3C2440_UFSTAT_TXFULL,
> .rxfifo_mask = S3C2440_UFSTAT_RXFULL | S3C2440_UFSTAT_RXMASK,
> @@ -2758,10 +2748,6 @@ static int __init s3c2440_early_console_setup(struct earlycon_device *device,
> return samsung_early_console_setup(device, opt);
> }
>
> -OF_EARLYCON_DECLARE(s3c2412, "samsung,s3c2412-uart",
> - s3c2440_early_console_setup);
> -OF_EARLYCON_DECLARE(s3c2440, "samsung,s3c2440-uart",
> - s3c2440_early_console_setup);
> OF_EARLYCON_DECLARE(s3c6400, "samsung,s3c6400-uart",
> s3c2440_early_console_setup);
>
> --
> 2.40.1
>
>

2023-10-19 14:33:46

by Sam Protsenko

Subject: Re: [PATCH 2/2] dt-bindings: serial: drop unsupported samsung bindings

On Thu, Oct 19, 2023 at 5:06 AM André Draszik <[email protected]> wrote:
>
> Now that no implementation exists anymore for
> samsung,s3c24(1[02]|40)-uart, remove those bindings from here as well.
>
> Signed-off-by: André Draszik <[email protected]>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 8bd88d5cbb11..d45079ef7bd9 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -24,9 +24,6 @@ properties:
> - enum:
> - apple,s5l-uart
> - axis,artpec8-uart
> - - samsung,s3c2410-uart
> - - samsung,s3c2412-uart
> - - samsung,s3c2440-uart
> - samsung,s3c6400-uart
> - samsung,s5pv210-uart
> - samsung,exynos4210-uart
> @@ -96,7 +93,6 @@ allOf:
> compatible:
> contains:
> enum:
> - - samsung,s3c2410-uart
> - samsung,s5pv210-uart
> then:
> properties:
> --
> 2.40.1
>
>