2014-11-22 12:00:56

by SF Markus Elfring

Subject: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table"

From: Markus Elfring <[email protected]>
Date: Sat, 22 Nov 2014 12:55:28 +0100

The free_tce_table() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
arch/x86/kernel/pci-calgary_64.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index 0497f71..d22a386 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -1476,8 +1476,7 @@ cleanup:
for (--bus; bus >= 0; --bus) {
struct calgary_bus_info *info = &bus_info[bus];

- if (info->tce_space)
- free_tce_table(info->tce_space);
+ free_tce_table(info->tce_space);
}
return -ENOMEM;
}
--
2.1.3

2014-11-25 15:49:04

by Jon Mason

Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table"

On Sat, Nov 22, 2014 at 7:00 AM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Sat, 22 Nov 2014 12:55:28 +0100
>
> The free_tce_table() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Looks good to me

Acked-by: Jon Mason <[email protected]>


> ---
> arch/x86/kernel/pci-calgary_64.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
> index 0497f71..d22a386 100644
> --- a/arch/x86/kernel/pci-calgary_64.c
> +++ b/arch/x86/kernel/pci-calgary_64.c
> @@ -1476,8 +1476,7 @@ cleanup:
> for (--bus; bus >= 0; --bus) {
> struct calgary_bus_info *info = &bus_info[bus];
>
> - if (info->tce_space)
> - free_tce_table(info->tce_space);
> + free_tce_table(info->tce_space);
> }
> return -ENOMEM;
> }
> --
> 2.1.3
>

2015-06-27 15:29:20

by SF Markus Elfring

Subject: Re: [PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table"

>> From: Markus Elfring <[email protected]>
>> Date: Sat, 22 Nov 2014 12:55:28 +0100
>>
>> The free_tce_table() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <[email protected]>
>
> Looks good to me
>
> Acked-by: Jon Mason <[email protected]>
>
>
>> ---
>> arch/x86/kernel/pci-calgary_64.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
>> index 0497f71..d22a386 100644
>> --- a/arch/x86/kernel/pci-calgary_64.c
>> +++ b/arch/x86/kernel/pci-calgary_64.c
>> @@ -1476,8 +1476,7 @@ cleanup:
>> for (--bus; bus >= 0; --bus) {
>> struct calgary_bus_info *info = &bus_info[bus];
>>
>> - if (info->tce_space)
>> - free_tce_table(info->tce_space);
>> + free_tce_table(info->tce_space);
>> }
>> return -ENOMEM;
>> }
>> --
>> 2.1.3
>>

Do the chances increase to integrate this update suggestion
into another source code repository?

Regards,
Markus