2015-06-09 06:52:56

by Hyuk Myeong

[permalink] [raw]
Subject: [PATCH] ARM: pgtable: Fix typo in the comment

This patch fix a spelling typo in the comment in pgtable-2level.h.

Signed-off-by: Hyuk Myeong <[email protected]>
---
arch/arm/include/asm/pgtable-2level.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/include/asm/pgtable-2level.h
b/arch/arm/include/asm/pgtable-2level.h
index bfd662e..49f91be 100644
--- a/arch/arm/include/asm/pgtable-2level.h
+++ b/arch/arm/include/asm/pgtable-2level.h
@@ -66,7 +66,7 @@
*
* However, when the "young" bit is cleared, we deny access to the page
* by clearing the hardware PTE. Currently Linux does not flush the TLB
- * for us in this case, which means the TLB will retain the transation
+ * for us in this case, which means the TLB will retain the transaction
* until either the TLB entry is evicted under pressure, or a context
* switch which changes the user space mapping occurs.
*/
--
1.9.3


2015-06-09 08:42:39

by Steve Capper

[permalink] [raw]
Subject: Re: [PATCH] ARM: pgtable: Fix typo in the comment

On 9 June 2015 at 07:52, Hyuk Myeong <[email protected]> wrote:
> This patch fix a spelling typo in the comment in pgtable-2level.h.
>

Hi Hyuk,

> Signed-off-by: Hyuk Myeong <[email protected]>
> ---
> arch/arm/include/asm/pgtable-2level.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/pgtable-2level.h
> b/arch/arm/include/asm/pgtable-2level.h
> index bfd662e..49f91be 100644
> --- a/arch/arm/include/asm/pgtable-2level.h
> +++ b/arch/arm/include/asm/pgtable-2level.h
> @@ -66,7 +66,7 @@
> *
> * However, when the "young" bit is cleared, we deny access to the page
> * by clearing the hardware PTE. Currently Linux does not flush the TLB
> - * for us in this case, which means the TLB will retain the transation
> + * for us in this case, which means the TLB will retain the transaction

Don't you mean "translation" rather than "transaction"?

Cheers,
--
Steve

> * until either the TLB entry is evicted under pressure, or a context
> * switch which changes the user space mapping occurs.
> */
> --
> 1.9.3
>

2015-06-10 02:34:00

by Hyuk Myeong

[permalink] [raw]
Subject: RE: [PATCH] ARM: pgtable: Fix typo in the comment

Hello Steve,

On Tue, June 09, 2015 5:43 PM, Steve Capper <[email protected]> wrote:
> On 9 June 2015 at 07:52, Hyuk Myeong <[email protected]> wrote:
>> This patch fix a spelling typo in the comment in pgtable-2level.h.
>>
>
> Hi Hyuk,
>
>> Signed-off-by: Hyuk Myeong <[email protected]>
>> ---
>> arch/arm/include/asm/pgtable-2level.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/include/asm/pgtable-2level.h
>> b/arch/arm/include/asm/pgtable-2level.h
>> index bfd662e..49f91be 100644
>> --- a/arch/arm/include/asm/pgtable-2level.h
>> +++ b/arch/arm/include/asm/pgtable-2level.h
>> @@ -66,7 +66,7 @@
>> *
>> * However, when the "young" bit is cleared, we deny access to the page
>> * by clearing the hardware PTE. Currently Linux does not flush the TLB
>> - * for us in this case, which means the TLB will retain the transation
>> + * for us in this case, which means the TLB will retain the transaction
>
> Don't you mean "translation" rather than "transaction"?
> Cheers,


Thank you for the advice
I had been confused between the two because I assumed that "transaction"
is not that bad in this context (as a set of the translation)

Like you said, if "translation" is better here than I will send a new patch