2021-03-01 03:48:27

by Chen Jun

Subject: [Reoprt] Some compile warning on ppc dts

Hi

After run the following commands
make distclean
make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-

I get some warning:
arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge):
/pci@f0000d00: missing ranges for PCI bridg
e (or not a bridge)
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed
prerequisite 'pci_bridge'
arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning
(spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
or SPI buses should be 'spi'
also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed
prerequisite 'spi_bus_bridge'
...

For the problem about "node name for SPI buses should be 'spi'":
Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can
fix it.
diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
index 6661955a2be4..cd3dc70cd72e 100644
--- a/arch/powerpc/boot/dts/o2d.dtsi
+++ b/arch/powerpc/boot/dts/o2d.dtsi
@@ -29,7 +29,7 @@ rtc@800 {
>------>------->-------status = "disabled";
>------>-------};
-
->------>-------psc@2000 {>----->-------// PSC1
+>------>-------spi@2000 {>----->-------// PSC1
>------>------->-------compatible =
"fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
>------>------->-------#address-cells = <1>;
>------>------->-------#size-cells = <0>;
---

For the problem about "missing ranges for PCI bridge (or not a bridge)":
Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
>-------pci: pci@f0000d00 {
>------->-------#interrupt-cells = <1>;
>------->-------#size-cells = <2>;
>------->-------#address-cells = <3>;
>------->-------device_type = "pci";
>------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
>------->-------reg = <0xf0000d00 0x100>;
>------->-------// interrupt-map-mask = need to add
>------->-------// interrupt-map = need to add
>------->-------clock-frequency = <0>; // From boot loader
>------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
>------->-------bus-range = <0 0>;
>------->-------// ranges = need to add
>-------};
I think the ranges should be add by someone who knows the mpc5200 better.

Can anyone fix this?

--
Regards
Chen Jun

2022-03-02 23:40:37

by Christophe Leroy

Subject: Re: [Reoprt] Some compile warning on ppc dts

Le 01/03/2021 à 03:16, chenjun (AM) a écrit :
> Hi
>
> After run the following commands
> make distclean
> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
>
> I get some warning:
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge):
> /pci@f0000d00: missing ranges for PCI bridg
> e (or not a bridge)
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed
> prerequisite 'pci_bridge'
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning
> (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
> or SPI buses should be 'spi'
> also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
> ...
>
> For the problem about "node name for SPI buses should be 'spi'":
> Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can
> fix it.
> diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
> index 6661955a2be4..cd3dc70cd72e 100644
> --- a/arch/powerpc/boot/dts/o2d.dtsi
> +++ b/arch/powerpc/boot/dts/o2d.dtsi
> @@ -29,7 +29,7 @@ rtc@800 {
> >------>------->-------status = "disabled";
> >------>-------};
> -
> ->------>-------psc@2000 {>----->-------// PSC1
> +>------>-------spi@2000 {>----->-------// PSC1
> >------>------->-------compatible =
> "fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
> >------>------->-------#address-cells = <1>;
> >------>------->-------#size-cells = <0>;
> ---
>
> For the problem about "missing ranges for PCI bridge (or not a bridge)":
> Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
> >-------pci: pci@f0000d00 {
> >------->-------#interrupt-cells = <1>;
> >------->-------#size-cells = <2>;
> >------->-------#address-cells = <3>;
> >------->-------device_type = "pci";
> >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
> >------->-------reg = <0xf0000d00 0x100>;
> >------->-------// interrupt-map-mask = need to add
> >------->-------// interrupt-map = need to add
> >------->-------clock-frequency = <0>; // From boot loader
> >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
> >------->-------bus-range = <0 0>;
> >------->-------// ranges = need to add
> >-------};
> I think the ranges should be add by someone who knows the mpc5200 better.
>


This patch has garbage instead of tabs, it doesn't apply