If the "ngpios" property is specified, bgpio_bits is calculated
as the round up value of ngpio. At the moment, the only requirement
specified is that the round up value must be a multiple of 8 but
it should also be a power of 2 because we provide accessors based
on the bank size in bgpio_setup_accessors().
Signed-off-by: Asmaa Mnebhi <[email protected]>
---
drivers/gpio/gpio-mmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index b52a3dd511ca..74fdf0d87b2c 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -623,7 +623,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
if (ret)
gc->ngpio = gc->bgpio_bits;
else
- gc->bgpio_bits = round_up(gc->ngpio, 8);
+ gc->bgpio_bits = roundup_pow_of_two(round_up(gc->ngpio, 8));
ret = bgpio_setup_io(gc, dat, set, clr, flags);
if (ret)
--
2.30.1
On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <[email protected]> wrote:
>
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
Reviewed-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Asmaa Mnebhi <[email protected]>
> ---
> drivers/gpio/gpio-mmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
> index b52a3dd511ca..74fdf0d87b2c 100644
> --- a/drivers/gpio/gpio-mmio.c
> +++ b/drivers/gpio/gpio-mmio.c
> @@ -623,7 +623,7 @@ int bgpio_init(struct gpio_chip *gc, struct device *dev,
> if (ret)
> gc->ngpio = gc->bgpio_bits;
> else
> - gc->bgpio_bits = round_up(gc->ngpio, 8);
> + gc->bgpio_bits = roundup_pow_of_two(round_up(gc->ngpio, 8));
>
> ret = bgpio_setup_io(gc, dat, set, clr, flags);
> if (ret)
> --
> 2.30.1
>
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 24, 2023 at 2:07 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <[email protected]> wrote:
> >
> > If the "ngpios" property is specified, bgpio_bits is calculated
> > as the round up value of ngpio. At the moment, the only requirement
> > specified is that the round up value must be a multiple of 8 but
> > it should also be a power of 2 because we provide accessors based
> > on the bank size in bgpio_setup_accessors().
>
> Reviewed-by: Andy Shevchenko <[email protected]>
Btw, I do not see the initial patch in Bart's tree. I suppose you may
simply send a v5 of the original one with this fix applied inplace.
--
With Best Regards,
Andy Shevchenko
> > >
> > > If the "ngpios" property is specified, bgpio_bits is calculated as
> > > the round up value of ngpio. At the moment, the only requirement
> > > specified is that the round up value must be a multiple of 8 but it
> > > should also be a power of 2 because we provide accessors based on
> > > the bank size in bgpio_setup_accessors().
> >
> > Reviewed-by: Andy Shevchenko <[email protected]>
>
> Btw, I do not see the initial patch in Bart's tree. I suppose you may simply
> send a v5 of the original one with this fix applied inplace.
>
Yes I was not able to find it on any branch yet so I just sent this patch based the other one.
On Thu, Mar 23, 2023 at 9:57 PM Asmaa Mnebhi <[email protected]> wrote:
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <[email protected]>
Neat fixup,
Reviewed-by: Linus Walleij <[email protected]>
Yours,
Linus Walleij
> Reviewed-by: Andy Shevchenko <[email protected]>
>
Hi Bart,
Could you please add this patch to the tree?
Thanks.
Asmaa
On Mon, Jul 10, 2023 at 7:26 PM Asmaa Mnebhi <[email protected]> wrote:
>
> > Reviewed-by: Andy Shevchenko <[email protected]>
> >
> Hi Bart,
>
> Could you please add this patch to the tree?
>
> Thanks.
> Asmaa
You still haven't sent it to my address and it's not rebased on top of v6.5-rc1.
Bart