+Abhijeet
@Benson Leung @Malani, Prashant Please provide your comments.
-----Original Message-----
From: Mika Westerberg <[email protected]>
Sent: Wednesday, August 3, 2022 11:07 AM
To: Khandelwal, Rajat <[email protected]>
Cc: [email protected]; Jamet, Michael <[email protected]>; [email protected]; [email protected]; [email protected]; Malani, Prashant <[email protected]>; [email protected]
Subject: Re: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers
Hi,
On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend
> and simultaneously project the screen on an external display connected
> to a TBT/USB4 device. This patch enables this feature.
>
> Let me know what you think about this.
Please prefix patches to follow the sybsystem style. For Thunderbolt it
should be "thunderbolt: ....".
This will cause any monitor plug to wake up the system and I'm not sure
we want that, at least to be default behaviour. If you have a regular
Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it
wake up?
IIRC I already suggested you to do this for the USB4 ports themselves
(struct usb4_port) so that userspace can make them wake up the system on
any event by writing "enabled > .../wakeup" which is the normal way.
-----Original Message-----
From: Khandelwal, Rajat
Sent: Wednesday, August 3, 2022 1:00 PM
To: Mika Westerberg <[email protected]>; Malani, Prashant <[email protected]>; [email protected]
Cc: [email protected]; Jamet, Michael <[email protected]>; [email protected]; [email protected]; [email protected]; Rao, Abhijeet <[email protected]>
Subject: RE: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers
+Abhijeet
@Benson Leung @Malani, Prashant Please provide your comments.
-----Original Message-----
From: Mika Westerberg <[email protected]>
Sent: Wednesday, August 3, 2022 11:07 AM
To: Khandelwal, Rajat <[email protected]>
Cc: [email protected]; Jamet, Michael <[email protected]>; [email protected]; [email protected]; [email protected]; Malani, Prashant <[email protected]>; [email protected]
Subject: Re: [PATCH] thunderbolt: Supporting wake on DP hot events behind TBT/USB4 routers
Hi,
On Wed, Aug 03, 2022 at 06:31:39AM +0530, Rajat Khandelwal wrote:
> Current implementation doesn't allow user to go into system suspend
> and simultaneously project the screen on an external display connected
> to a TBT/USB4 device. This patch enables this feature.
>
> Let me know what you think about this.
Please prefix patches to follow the sybsystem style. For Thunderbolt it should be "thunderbolt: ....".
This will cause any monitor plug to wake up the system and I'm not sure we want that, at least to be default behaviour. If you have a regular Type-C (non-USB4/TBT) dock and you plug in a monitor to that, does it wake up?
IIRC I already suggested you to do this for the USB4 ports themselves (struct usb4_port) so that userspace can make them wake up the system on any event by writing "enabled > .../wakeup" which is the normal way.
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Wed, Aug 03, 2022 at 07:29:36AM +0000, Khandelwal, Rajat wrote:
> +Abhijeet
> @Benson Leung @Malani, Prashant Please provide your comments.
On Wed, Aug 03, 2022 at 07:31:30AM +0000, Khandelwal, Rajat wrote:
>
What did you write here?
confused,
greg k-h