2022-10-18 02:46:41

by ye xingchen

Subject: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__

From: ye xingchen <[email protected]>

__FUNCTION__ exists only for backwards compatibility reasons with old
gcc versions. Replace it with __func__.

Signed-off-by: ye xingchen <[email protected]>
Reviewed-by: Jesse Brandeburg <[email protected]>
---
v1 -> v2
Fix the message up to use ("message in %s\n", __func__)
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 3fc572341781..efa2692af577 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
iavf_close(netdev);

if (iavf_lock_timeout(&adapter->crit_lock, 5000))
- dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
+ dev_warn(&adapter->pdev->dev, "%s: failed to acquire crit_lock\n", __func__);
/* Prevent the watchdog from running. */
iavf_change_state(adapter, __IAVF_REMOVE);
adapter->aq_required = 0;
--
2.25.1

2022-10-18 20:48:30

by Jacob Keller

Subject: RE: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Monday, October 17, 2022 6:52 PM
> To: Brandeburg, Jesse <[email protected]>
> Cc: Nguyen, Anthony L <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]; Keller, Jacob E
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; ye xingchen
> <[email protected]>
> Subject: [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__
>
> From: ye xingchen <[email protected]>
>
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
>
> Signed-off-by: ye xingchen <[email protected]>
> Reviewed-by: Jesse Brandeburg <[email protected]>

Thanks for cleaning this up!

Reviewed-by: Jacob Keller <[email protected]>

> ---
> v1 -> v2
> Fix the message up to use ("message in %s\n", __func__)
> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..efa2692af577 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
> iavf_close(netdev);
>
> if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> - dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in
> %s\n", __FUNCTION__);
> + dev_warn(&adapter->pdev->dev, "%s: failed to acquire
> crit_lock\n", __func__);
> /* Prevent the watchdog from running. */
> iavf_change_state(adapter, __IAVF_REMOVE);
> adapter->aq_required = 0;
> --
> 2.25.1

2022-10-27 06:32:22

by Jankowski, Konrad0

Subject: RE: [Intel-wired-lan] [PATCH linux-next v2] iavf: Replace __FUNCTION__ with __func__

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> [email protected]
> Sent: Tuesday, October 18, 2022 3:52 AM
> To: Brandeburg, Jesse <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; ye xingchen
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH linux-next v2] iavf: Replace __FUNCTION__ with
> __func__
>
> From: ye xingchen <[email protected]>
>
> __FUNCTION__ exists only for backwards compatibility reasons with old gcc
> versions. Replace it with __func__.
>
> Signed-off-by: ye xingchen <[email protected]>
> Reviewed-by: Jesse Brandeburg <[email protected]>
> ---
> v1 -> v2
> Fix the message up to use ("message in %s\n", __func__)
> drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..efa2692af577 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c

Tested-by: Konrad Jankowski <[email protected]>