2024-03-25 13:52:33

by Su Hui

Subject: [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open()

otx2_rxtx_enable() return negative error code such as -EIO,
check -EIO rather than EIO to fix this problem.

Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit")
Signed-off-by: Su Hui <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index b40bd0e46751..3f46d5e0fb2e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -1933,7 +1933,7 @@ int otx2_open(struct net_device *netdev)
* mcam entries are enabled to receive the packets. Hence disable the
* packet I/O.
*/
- if (err == EIO)
+ if (err == -EIO)
goto err_disable_rxtx;
else if (err)
goto err_tx_stop_queues;
--
2.30.2

2024-03-25 15:23:00

by Subbaraya Sundeep Bhatta

Subject: RE: [EXTERNAL] [PATCH 1/2] octeontx2-pf: check negative error code in otx2_open()

>-----Original Message-----
>From: Su Hui <[email protected]>
>Sent: Monday, March 25, 2024 1:06 PM
>To: Sunil Kovvuri Goutham <[email protected]>; Geethasowjanya Akula
><[email protected]>; Subbaraya Sundeep Bhatta <[email protected]>;
>Hariprasad Kelam <[email protected]>; [email protected];
>[email protected]; [email protected]; [email protected]
>Cc: Su Hui <[email protected]>; Sai Krishna Gajula
><[email protected]>; [email protected]; linux-
>[email protected]; [email protected]
>Subject: [PATCH 1/2] octeontx2-pf: check negative error code in
>otx2_open()
>
>otx2_rxtx_enable() return negative error code such as -EIO,
>check -EIO rather than EIO to fix this problem.
>
>Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit")
>Signed-off-by: Su Hui <[email protected]>

Reviewed-by: Subbaraya Sundeep <[email protected]>