2017-06-26 23:33:01

by Quytelda Kahja

Subject: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.

Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.

Signed-off-by: Quytelda Kahja <[email protected]>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index a692561c81c8..b6caa7a98692 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
err_debugfs_dir:
debugfs_remove_recursive(dev->debugfs_dir);
kfree(hdr_info);
- dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
+ dev_err(&dev->device, "%s failed: %d\n", __func__, err);
return err;
}

--
2.13.2

2017-06-27 20:37:57

by Kershner, David A

Subject: RE: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.

> -----Original Message-----
> From: Quytelda Kahja [mailto:[email protected]]
> Sent: Monday, June 26, 2017 7:32 PM
> To: Kershner, David A <[email protected]>;
> [email protected]; Sell, Timothy C <[email protected]>;
> Binder, David Anthony <[email protected]>
> Cc: [email protected]; [email protected]; Quytelda
> Kahja <[email protected]>
> Subject: [PATCH] Staging: visorbus: Fix coding style warning from
> checkpatch.pl.
>
> Replace the literal function name "create_bus_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
>
> Signed-off-by: Quytelda Kahja <[email protected]>

I can't get this to apply to Greg's staging-next branch. It appears to be missing
at least patch:

commit 9e78fd35d staging: unisys: visorbus: renamed functions like *_bus_instance
to match driver namespace

Please update and send again.

Thanks,
David Kershner

> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561c81c8..b6caa7a98692 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
> err_debugfs_dir:
> debugfs_remove_recursive(dev->debugfs_dir);
> kfree(hdr_info);
> - dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
> + dev_err(&dev->device, "%s failed: %d\n", __func__, err);
> return err;
> }
>
> --
> 2.13.2