2020-04-15 22:30:56

by Jason Yan

Subject: [PATCH] ACPICA: make acpi_protocol_lengths static

Fix the following sparse warning:

drivers/acpi/acpica/exfield.c:25:10: warning: symbol
'acpi_protocol_lengths' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/acpi/acpica/exfield.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
index e85eb31e5075..3323a2ba6a31 100644
--- a/drivers/acpi/acpica/exfield.c
+++ b/drivers/acpi/acpica/exfield.c
@@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
*/
#define ACPI_INVALID_PROTOCOL_ID 0x80
#define ACPI_MAX_PROTOCOL_ID 0x0F
-const u8 acpi_protocol_lengths[] = {
+static const u8 acpi_protocol_lengths[] = {
ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
0x00, /* 2 - ATTRIB_QUICK */
--
2.21.1

2020-04-15 22:50:30

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPICA: make acpi_protocol_lengths static

On Wed, Apr 15, 2020 at 10:23 AM Jason Yan <[email protected]> wrote:
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol
> 'acpi_protocol_lengths' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>

Erik, Bob, this one is yours. :-)

> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
> index e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1
>

2020-04-16 00:18:04

by Kaneda, Erik

Subject: RE: [PATCH] ACPICA: make acpi_protocol_lengths static

> -----Original Message-----
> From: Jason Yan <[email protected]>
> Sent: Wednesday, April 15, 2020 1:50 AM
> To: Moore, Robert <[email protected]>; Kaneda, Erik
> <[email protected]>; Wysocki, Rafael J <[email protected]>;
> [email protected]; [email protected]; [email protected]; linux-
> [email protected]
> Cc: Jason Yan <[email protected]>; Hulk Robot <[email protected]>
> Subject: [PATCH] ACPICA: make acpi_protocol_lengths static
>
> Fix the following sparse warning:
>
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol 'acpi_protocol_lengths'
> was not declared. Should it be static?

This has already been reported and I've made the appropriate fix in the ACPICA code base already. it should be available in the next ACPICA release

Thanks,
Erik
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/acpi/acpica/exfield.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c index
> e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
> */
> #define ACPI_INVALID_PROTOCOL_ID 0x80
> #define ACPI_MAX_PROTOCOL_ID 0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
> ACPI_INVALID_PROTOCOL_ID, /* 0 - reserved */
> ACPI_INVALID_PROTOCOL_ID, /* 1 - reserved */
> 0x00, /* 2 - ATTRIB_QUICK */
> --
> 2.21.1