Currently Tegra Note 7 uses tn7 compatible and device tree name which is
not quite correct. This device has proper codename which is tegratab.
Switch tn7 in compatible to tegratab and set a better device tree name
tegra114-nvidia-tegratab which aligns with newer trees.
Svyatoslav Ryhel (2):
ARM: tegra: set correct naming for Tegra Note 7
dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly
Documentation/devicetree/bindings/arm/tegra.yaml | 5 ++++-
arch/arm/boot/dts/nvidia/Makefile | 4 ++--
.../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
3 files changed, 9 insertions(+), 5 deletions(-)
rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
--
2.40.1
Correct codename of Tegra Note 7 is "tegratab", while model
name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
Signed-off-by: Svyatoslav Ryhel <[email protected]>
---
arch/arm/boot/dts/nvidia/Makefile | 4 ++--
.../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
index 7a422f150488..474f3fbbd99d 100644
--- a/arch/arm/boot/dts/nvidia/Makefile
+++ b/arch/arm/boot/dts/nvidia/Makefile
@@ -2,8 +2,8 @@
dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \
tegra114-asus-tf701t.dtb \
tegra114-dalmore.dtb \
- tegra114-roth.dtb \
- tegra114-tn7.dtb
+ tegra114-nvidia-tegratab.dtb \
+ tegra114-roth.dtb
dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \
tegra124-apalis-eval.dtb \
tegra124-apalis-v1.2-eval.dtb \
diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
similarity index 98%
rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
index bfbdb345575a..30b2ed91be23 100644
--- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
+++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
@@ -5,8 +5,9 @@
#include "tegra114.dtsi"
/ {
- model = "Tegra Note 7";
- compatible = "nvidia,tn7", "nvidia,tegra114";
+ model = "NVIDIA Tegra Note 7";
+ compatible = "nvidia,tegratab", "nvidia,tegra114";
+ chassis-type = "tablet";
chosen {
/* TN7's bootloader's arguments need to be overridden */
--
2.40.1
On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> Currently Tegra Note 7 uses tn7 compatible and device tree name which is
> not quite correct. This device has proper codename which is tegratab.
Certainly news to me :-)
I have always known it as Tegra Note 7 and so 'tn7' as an abbreviation
seems fine.
Jon
--
nvpublic
On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> Correct codename of Tegra Note 7 is "tegratab", while model
> name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
>
> Signed-off-by: Svyatoslav Ryhel <[email protected]>
> ---
> arch/arm/boot/dts/nvidia/Makefile | 4 ++--
> .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
> rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
>
> diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> index 7a422f150488..474f3fbbd99d 100644
> --- a/arch/arm/boot/dts/nvidia/Makefile
> +++ b/arch/arm/boot/dts/nvidia/Makefile
> @@ -2,8 +2,8 @@
> dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \
> tegra114-asus-tf701t.dtb \
> tegra114-dalmore.dtb \
> - tegra114-roth.dtb \
> - tegra114-tn7.dtb
> + tegra114-nvidia-tegratab.dtb \
> + tegra114-roth.dtb
> dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \
> tegra124-apalis-eval.dtb \
> tegra124-apalis-v1.2-eval.dtb \
> diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> similarity index 98%
> rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> index bfbdb345575a..30b2ed91be23 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> @@ -5,8 +5,9 @@
> #include "tegra114.dtsi"
>
> / {
> - model = "Tegra Note 7";
> - compatible = "nvidia,tn7", "nvidia,tegra114";
> + model = "NVIDIA Tegra Note 7";
> + compatible = "nvidia,tegratab", "nvidia,tegra114";
> + chassis-type = "tablet";
No mention of adding the chassis-type in the commit message. Seems like
that should be a separate change.
Jon
--
nvpublic
On Mon Feb 12, 2024 at 5:14 PM CET, Jon Hunter wrote:
>
> On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> > Correct codename of Tegra Note 7 is "tegratab", while model
> > name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
> >
> > Signed-off-by: Svyatoslav Ryhel <[email protected]>
> > ---
> > arch/arm/boot/dts/nvidia/Makefile | 4 ++--
> > .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
> > 2 files changed, 5 insertions(+), 4 deletions(-)
> > rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
> >
> > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile
> > index 7a422f150488..474f3fbbd99d 100644
> > --- a/arch/arm/boot/dts/nvidia/Makefile
> > +++ b/arch/arm/boot/dts/nvidia/Makefile
> > @@ -2,8 +2,8 @@
> > dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \
> > tegra114-asus-tf701t.dtb \
> > tegra114-dalmore.dtb \
> > - tegra114-roth.dtb \
> > - tegra114-tn7.dtb
> > + tegra114-nvidia-tegratab.dtb \
> > + tegra114-roth.dtb
> > dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \
> > tegra124-apalis-eval.dtb \
> > tegra124-apalis-v1.2-eval.dtb \
> > diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > similarity index 98%
> > rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > index bfbdb345575a..30b2ed91be23 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > @@ -5,8 +5,9 @@
> > #include "tegra114.dtsi"
> >
> > / {
> > - model = "Tegra Note 7";
> > - compatible = "nvidia,tn7", "nvidia,tegra114";
> > + model = "NVIDIA Tegra Note 7";
> > + compatible = "nvidia,tegratab", "nvidia,tegra114";
> > + chassis-type = "tablet";
>
> No mention of adding the chassis-type in the commit message. Seems like
> that should be a separate change.
Agreed. Along with Krzysztof's comments maybe this should just be a
single patch that updates the model property and adds the chassis-type.
We haven't used chassis-type before, but I see that the devicetree
specification has it marked as "optional-but-recommended", so maybe we
should make a pass over all files and add these as appropriate.
Thierry