2024-02-16 08:18:58

by Petlozu Pravareshwar

[permalink] [raw]
Subject: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

From: Prathamesh Shete <[email protected]>

Add SD wake event for Tegra234 so that system can be woken up from
suspend when SD card hot-plug/unplug event is detected.

Signed-off-by: Prathamesh Shete <[email protected]>
Signed-off-by: Petlozu Pravareshwar <[email protected]>
---
drivers/soc/tegra/pmc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
index 6dfcc7f50ece..dc4eab3191c2 100644
--- a/drivers/soc/tegra/pmc.c
+++ b/drivers/soc/tegra/pmc.c
@@ -3,7 +3,7 @@
* drivers/soc/tegra/pmc.c
*
* Copyright (c) 2010 Google, Inc
- * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
+ * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
*
* Author:
* Colin Cross <[email protected]>
@@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
TEGRA_WAKE_IRQ("pmu", 24, 209),
TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
+ TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
TEGRA_WAKE_IRQ("rtc", 73, 10),
TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),
};
--
2.43.0



2024-02-16 11:34:51

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> From: Prathamesh Shete <[email protected]>
>
> Add SD wake event for Tegra234 so that system can be woken up from
> suspend when SD card hot-plug/unplug event is detected.
>
> Signed-off-by: Prathamesh Shete <[email protected]>
> Signed-off-by: Petlozu Pravareshwar <[email protected]>
> ---
> drivers/soc/tegra/pmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 6dfcc7f50ece..dc4eab3191c2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
> * drivers/soc/tegra/pmc.c
> *
> * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> *
> * Author:
> * Colin Cross <[email protected]>
> @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),

I'd prefer to stick with - instead of _ in these names, like we do with
sw-wake. No need to resend, I can make that change when applying,
provided you don't have any objections.

Thierry

> TEGRA_WAKE_IRQ("rtc", 73, 10),
> TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179),
> };

Attachments:
signature.asc (849.00 B)

2024-02-16 11:36:56

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> From: Prathamesh Shete <[email protected]>
>
> Add SD wake event for Tegra234 so that system can be woken up from
> suspend when SD card hot-plug/unplug event is detected.
>
> Signed-off-by: Prathamesh Shete <[email protected]>
> Signed-off-by: Petlozu Pravareshwar <[email protected]>
> ---
> drivers/soc/tegra/pmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 6dfcc7f50ece..dc4eab3191c2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
> * drivers/soc/tegra/pmc.c
> *
> * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> *
> * Author:
> * Colin Cross <[email protected]>
> @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event tegra234_wake_events[] = {
> TEGRA_WAKE_IRQ("pmu", 24, 209),
> TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),

These are also meant to be ordered by wake ID, so I've moved this up to
where it belongs.

Thierry

Attachments:
signature.asc (849.00 B)

2024-02-16 12:37:12

by Petlozu Pravareshwar

[permalink] [raw]
Subject: RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

> On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> > From: Prathamesh Shete <[email protected]>
> >
> > Add SD wake event for Tegra234 so that system can be woken up from
> > suspend when SD card hot-plug/unplug event is detected.
> >
> > Signed-off-by: Prathamesh Shete <[email protected]>
> > Signed-off-by: Petlozu Pravareshwar <[email protected]>
> > ---
> > drivers/soc/tegra/pmc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index
> > 6dfcc7f50ece..dc4eab3191c2 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> > * drivers/soc/tegra/pmc.c
> > *
> > * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> > *
> > * Author:
> > * Colin Cross <[email protected]>
> > @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event
> tegra234_wake_events[] = {
> > TEGRA_WAKE_IRQ("pmu", 24, 209),
> > TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> > TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> > + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
>
> I'd prefer to stick with - instead of _ in these names, like we do with sw-wake.
> No need to resend, I can make that change when applying, provided you
> don't have any objections.
>
Yes, let's stick with - only instead of _ in the names for consistency.
Thanks.

> Thierry
>
> > TEGRA_WAKE_IRQ("rtc", 73, 10),
> > TEGRA_WAKE_IRQ("sw-wake", SW_WAKE_ID, 179), };

2024-02-16 12:44:12

by Petlozu Pravareshwar

[permalink] [raw]
Subject: RE: [PATCH] soc/tegra: pmc: Add SD wake event for Tegra234

> On Fri Feb 16, 2024 at 9:04 AM CET, Petlozu Pravareshwar wrote:
> > From: Prathamesh Shete <[email protected]>
> >
> > Add SD wake event for Tegra234 so that system can be woken up from
> > suspend when SD card hot-plug/unplug event is detected.
> >
> > Signed-off-by: Prathamesh Shete <[email protected]>
> > Signed-off-by: Petlozu Pravareshwar <[email protected]>
> > ---
> > drivers/soc/tegra/pmc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index
> > 6dfcc7f50ece..dc4eab3191c2 100644
> > --- a/drivers/soc/tegra/pmc.c
> > +++ b/drivers/soc/tegra/pmc.c
> > @@ -3,7 +3,7 @@
> > * drivers/soc/tegra/pmc.c
> > *
> > * Copyright (c) 2010 Google, Inc
> > - * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
> > + * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
> > *
> > * Author:
> > * Colin Cross <[email protected]>
> > @@ -4199,6 +4199,7 @@ static const struct tegra_wake_event
> tegra234_wake_events[] = {
> > TEGRA_WAKE_IRQ("pmu", 24, 209),
> > TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
> > TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
> > + TEGRA_WAKE_GPIO("sd_wake", 8, 0, TEGRA234_MAIN_GPIO(G, 7)),
>
> These are also meant to be ordered by wake ID, so I've moved this up to
> where it belongs.
>
> Thierry
Got it. Thanks for taking care of this.