2017-06-24 16:27:02

by Christos Gkekas

Subject: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.

Variable idx is defined as u16 thus statement (idx < 0) is
always false and should be removed.

Signed-off-by: Christos Gkekas <[email protected]>
---
drivers/scsi/qedi/qedi_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
index e937490..19254bd 100644
--- a/drivers/scsi/qedi/qedi_fw.c
+++ b/drivers/scsi/qedi/qedi_fw.c
@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,

/* Obtain buffer address from rqe_opaque */
idx = cqe->rqe_opaque.lo;
- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+ if (idx > (QEDI_BDQ_NUM - 1)) {
QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
"wrong idx %d returned by FW, dropping the unsolicited pkt\n",
idx);
@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,

/* Obtain buffer address from rqe_opaque */
idx = cqe->rqe_opaque.lo;
- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+ if (idx > (QEDI_BDQ_NUM - 1)) {
QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
"wrong idx %d returned by FW, dropping the unsolicited pkt\n",
idx);
--
2.7.4

2017-06-26 07:17:33

by Rangankar, Manish

Subject: Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.

On 24/06/17 9:54 PM, "Christos Gkekas" <[email protected]> wrote:

>Variable idx is defined as u16 thus statement (idx < 0) is
>always false and should be removed.
>
>Signed-off-by: Christos Gkekas <[email protected]>
>---
> drivers/scsi/qedi/qedi_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
>index e937490..19254bd 100644
>--- a/drivers/scsi/qedi/qedi_fw.c
>+++ b/drivers/scsi/qedi/qedi_fw.c
>@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
>
> /* Obtain buffer address from rqe_opaque */
> idx = cqe->rqe_opaque.lo;
>- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+ if (idx > (QEDI_BDQ_NUM - 1)) {
> QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> idx);
>@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,
>
> /* Obtain buffer address from rqe_opaque */
> idx = cqe->rqe_opaque.lo;
>- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+ if (idx > (QEDI_BDQ_NUM - 1)) {
> QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> idx);
>--
>2.7.4

Acked-by: Manish Rangankar <[email protected]>

2017-06-26 17:44:14

by Martin K. Petersen

Subject: Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.

Christos,

> Variable idx is defined as u16 thus statement (idx < 0) is always
> false and should be removed.

Applied to 4.13/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering