2015-06-19 05:59:59

by Abdul, Hussain (H.)

Subject: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Abdul Hussain (6):
staging: comedi: dmm32at: Simplify a trivial if-return sequence
staging: comedi: fl512: Simplify a trivial if-return sequence
staging: comedi: daqboard2000: Simplify a trivial if-return sequence
staging: comedi: dac02: Simplify a trivial if-return sequence
staging: comedi: daq_dio24: Simplify a trivial if-return sequence
staging: comedi: s626: Simplify a trivial if-return sequence


drivers/staging/comedi/drivers/dac02.c | 6 +-----
drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
drivers/staging/comedi/drivers/dmm32at.c | 6 +-----
drivers/staging/comedi/drivers/fl512.c | 6 +-----
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
drivers/staging/comedi/drivers/s626.c | 6 +-----

2015-06-20 12:40:49

by Ian Abbott

Subject: Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence

On 19/06/15 06:59, Abdul, Hussain (H.) wrote:
>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Abdul Hussain (6):
> staging: comedi: dmm32at: Simplify a trivial if-return sequence
> staging: comedi: fl512: Simplify a trivial if-return sequence
> staging: comedi: daqboard2000: Simplify a trivial if-return sequence
> staging: comedi: dac02: Simplify a trivial if-return sequence
> staging: comedi: daq_dio24: Simplify a trivial if-return sequence
> staging: comedi: s626: Simplify a trivial if-return sequence
>
>
> drivers/staging/comedi/drivers/dac02.c | 6 +-----
> drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
> drivers/staging/comedi/drivers/dmm32at.c | 6 +-----
> drivers/staging/comedi/drivers/fl512.c | 6 +-----
> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
> drivers/staging/comedi/drivers/s626.c | 6 +-----


Looks good apart from the checkpatch warning in patch 3 as pointed out
by Sudip.

For patches 1-2 and 4-6:
Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-