2022-03-01 09:24:58

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
because platform_get_irq() already prints an error

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/power/supply/da9150-fg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
index e63fa62d1943..8c5e2c49d6c1 100644
--- a/drivers/power/supply/da9150-fg.c
+++ b/drivers/power/supply/da9150-fg.c
@@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)

/* Register IRQ */
irq = platform_get_irq_byname(pdev, "FG");
- if (irq < 0) {
- dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
+ if (irq < 0)
return irq;
- }

ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
IRQF_ONESHOT, "FG", fg);
--
2.20.1.7.g153144c


2022-03-03 10:39:00

by Adam Thomson

[permalink] [raw]
Subject: RE: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()

On 01 March 2022 08:16, Yang Li wrote:

> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Adam Thomson <[email protected]>

2022-03-04 21:24:12

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()

Hi,

On Tue, Mar 01, 2022 at 04:16:19PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/da9150-fg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index e63fa62d1943..8c5e2c49d6c1 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
>
> /* Register IRQ */
> irq = platform_get_irq_byname(pdev, "FG");
> - if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
> IRQF_ONESHOT, "FG", fg);
> --
> 2.20.1.7.g153144c
>

Attachments:
(No filename) (1.20 kB)
 signature.asc (849.00 B)
 Download all attachments