2017-03-16 07:01:59

by Miguel Bernal Marin

Subject: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply

Use kcalloc for allocating an array instead of kzalloc with multiply,
kcalloc is the preferred API.

Found with checkpatch.

Signed-off-by: Miguel Bernal Marin <[email protected]>
---
drivers/scsi/storvsc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 638e5f427c90..3d70d1cf49a3 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -866,7 +866,7 @@ static int storvsc_channel_init(struct hv_device *device, bool is_fc)
* We will however populate all the slots to evenly distribute
* the load.
*/
- stor_device->stor_chns = kzalloc(sizeof(void *) * num_possible_cpus(),
+ stor_device->stor_chns = kcalloc(num_possible_cpus(), sizeof(void *),
GFP_KERNEL);
if (stor_device->stor_chns == NULL)
return -ENOMEM;
--
2.12.0

2017-04-13 23:27:59

by KY Srinivasan

Subject: RE: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply

> -----Original Message-----
> From: Miguel Bernal Marin [mailto:[email protected]]
> Sent: Wednesday, March 15, 2017 11:58 PM
> To: KY Srinivasan <[email protected]>; Martin K. Petersen
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Haiyang Zhang <[email protected]>;
> Stephen Hemminger <[email protected]>; James E.J. Bottomley
> <[email protected]>
> Subject: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply
>
> Use kcalloc for allocating an array instead of kzalloc with multiply,
> kcalloc is the preferred API.
>
> Found with checkpatch.
>
> Signed-off-by: Miguel Bernal Marin <[email protected]>
Reviewed-by: K. Y. Srinivasan <[email protected]>


> ---
> drivers/scsi/storvsc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 638e5f427c90..3d70d1cf49a3 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -866,7 +866,7 @@ static int storvsc_channel_init(struct hv_device
> *device, bool is_fc)
> * We will however populate all the slots to evenly distribute
> * the load.
> */
> - stor_device->stor_chns = kzalloc(sizeof(void *) *
> num_possible_cpus(),
> + stor_device->stor_chns = kcalloc(num_possible_cpus(), sizeof(void
> *),
> GFP_KERNEL);
> if (stor_device->stor_chns == NULL)
> return -ENOMEM;
> --
> 2.12.0