2018-12-20 07:41:36

by Yue Haibing

Subject: [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

The return code should be check while qla4xxx_copy_from_fwddb_param
fails.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 949e186..1bc4db6 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha,

rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
fw_ddb_entry);
+ if (rc)
+ goto free_sess;

ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
__func__, fnode_sess->dev.kobj.name);
--
2.7.0

2018-12-24 08:52:33

by Manish Rangankar

Subject: RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

> -----Original Message-----
> From: YueHaibing <[email protected]>
> Sent: Thursday, December 20, 2018 8:46 AM
> To: [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; YueHaibing
> <[email protected]>
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
>
> External Email
>
> ----------------------------------------------------------------------
> External Email
>
> The return code should be check while qla4xxx_copy_from_fwddb_param fails.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/scsi/qla4xxx/ql4_os.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
>
> rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
> fw_ddb_entry);
> + if (rc)
> + goto free_sess;
>
> ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
> __func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
>

Thanks
Acked-by: Manish Rangankar <[email protected]>

2019-01-04 08:08:09

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

YueHaibing,

> The return code should be check while qla4xxx_copy_from_fwddb_param
> fails.

Applied to 4.21/scsi-fixes, thank you.

--
Martin K. Petersen Oracle Linux Engineering