2021-01-26 05:38:14

by Saurav Kashyap

[permalink] [raw]
Subject: RE: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption

Hi Dan,
Thanks for a patch.

> -----Original Message-----
> From: Dan Carpenter <[email protected]>
> Sent: Monday, January 25, 2021 2:14 PM
> To: Nilesh Javali <[email protected]>
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> [email protected]>; James E.J. Bottomley <[email protected]>;
> Martin K. Petersen <[email protected]>; Himanshu Madhani
> <[email protected]>; Saurav Kashyap
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
>
> External Email
>
> ----------------------------------------------------------------------
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
>
> Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host,
> target stats and initiator port")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index e45da05383cd..bee8cf9f8123 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
>
> bsg_reply->reply_payload_rcv_len =
> sg_copy_from_buffer(bsg_job-
> >reply_payload.sg_list,
> - bsg_job->reply_payload.sg_cnt,
> &data,
> + bsg_job->reply_payload.sg_cnt,
> data,
> sizeof(struct
> ql_vnd_tgt_stats_resp));
>
> bsg_reply->result = DID_OK;
> --

Acked-by: Saurav Kashyap <[email protected]>


> 2.29.2