2022-03-31 09:57:05

by Leon Romanovsky

Subject: [PATCH net v1] ixgbe: ensure IPsec VF<->PF compatibility

From: Leon Romanovsky <[email protected]>

The VF driver can forward any IPsec flags and such makes the function
is not extendable and prone to backward/forward incompatibility.

If new software runs on VF, it won't know that PF configured something
completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag.

Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
Reviewed-by: Raed Salem <[email protected]>
Signed-off-by: Leon Romanovsky <[email protected]>a
---
Chaagelog:
v1:
* Replaced bits arithmetic with more simple expression
v0: https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.1648637865.git.leonro@nvidia.com
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
index e596e1a9fc75..69d11ff7677d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
@@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
/* Tx IPsec offload doesn't seem to work on this
* device, so block these requests for now.
*/
- if (!(sam->flags & XFRM_OFFLOAD_INBOUND)) {
+ sam->flags = sam->flags & ~XFRM_OFFLOAD_IPV6;
+ if (sam->flags != XFRM_OFFLOAD_INBOUND) {
err = -EOPNOTSUPP;
goto err_out;
}
--
2.35.1

2022-04-01 15:02:32

by Shannon Nelson

Subject: Re: [PATCH net v1] ixgbe: ensure IPsec VF<->PF compatibility

On 3/31/22 1:20 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <[email protected]>
>
> The VF driver can forward any IPsec flags and such makes the function
> is not extendable and prone to backward/forward incompatibility.
>
> If new software runs on VF, it won't know that PF configured something
> completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag.
>
> Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
> Reviewed-by: Raed Salem <[email protected]>
> Signed-off-by: Leon Romanovsky <[email protected]>a


Thanks!

Reviewed-by: Shannon Nelson <[email protected]>


> ---
> Chaagelog:
> v1:
> * Replaced bits arithmetic with more simple expression
> v0: https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.1648637865.git.leonro@nvidia.com
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> index e596e1a9fc75..69d11ff7677d 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> @@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
> /* Tx IPsec offload doesn't seem to work on this
> * device, so block these requests for now.
> */
> - if (!(sam->flags & XFRM_OFFLOAD_INBOUND)) {
> + sam->flags = sam->flags & ~XFRM_OFFLOAD_IPV6;
> + if (sam->flags != XFRM_OFFLOAD_INBOUND) {
> err = -EOPNOTSUPP;
> goto err_out;
> }

2022-04-25 11:47:49

by Jankowski, Konrad0

Subject: RE: [Intel-wired-lan] [PATCH net v1] ixgbe: ensure IPsec VF<->PF compatibility

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Leon Romanovsky
> Sent: Thursday, March 31, 2022 10:20 AM
> To: David S . Miller <[email protected]>; Jakub Kicinski
> <[email protected]>
> Cc: Steffen Klassert <[email protected]>; Shannon Nelson
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; Jeff Kirsher
> <[email protected]>; Raed Salem <[email protected]>; Shannon
> Nelson <[email protected]>; Paolo Abeni <[email protected]>;
> Leon Romanovsky <[email protected]>
> Subject: [Intel-wired-lan] [PATCH net v1] ixgbe: ensure IPsec VF<->PF
> compatibility
>
> From: Leon Romanovsky <[email protected]>
>
> The VF driver can forward any IPsec flags and such makes the function is not
> extendable and prone to backward/forward incompatibility.
>
> If new software runs on VF, it won't know that PF configured something
> completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag.
>
> Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
> Reviewed-by: Raed Salem <[email protected]>
> Signed-off-by: Leon Romanovsky <[email protected]>a
> ---
> Chaagelog:
> v1:
> * Replaced bits arithmetic with more simple expression
> v0:
> https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.16
> [email protected]
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> index e596e1a9fc75..69d11ff7677d 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
> @@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter
> *adapter, u32 *msgbuf, u32 vf)

Tested-by: Konrad Jankowski <[email protected]>