2023-07-07 07:27:54

by 李扬韬

Subject: [PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <[email protected]>
---
drivers/gpu/drm/tiny/arcpgu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index e5b10e41554a..3a5e66d909a4 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -251,7 +251,6 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
struct device_node *encoder_node = NULL, *endpoint_node = NULL;
struct drm_connector *connector = NULL;
struct drm_device *drm = &arcpgu->drm;
- struct resource *res;
int ret;

arcpgu->clk = devm_clk_get(drm->dev, "pxlclk");
@@ -268,8 +267,7 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
drm->mode_config.max_height = 1080;
drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
+ arcpgu->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(arcpgu->regs))
return PTR_ERR(arcpgu->regs);

--
2.39.0

2023-07-07 13:39:36

by Alexey Brodkin

Subject: Re: [PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource()

Hi Yangtao,

> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <[email protected]>

Thanks for the improvement.

Acked-by: Alexey Brodkin <[email protected]>

> ---
> drivers/gpu/drm/tiny/arcpgu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
> index e5b10e41554a..3a5e66d909a4 100644
> --- a/drivers/gpu/drm/tiny/arcpgu.c
> +++ b/drivers/gpu/drm/tiny/arcpgu.c
> @@ -251,7 +251,6 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
> struct device_node *encoder_node = NULL, *endpoint_node = NULL;
> struct drm_connector *connector = NULL;
> struct drm_device *drm = &arcpgu->drm;
> - struct resource *res;
> int ret;
>
> arcpgu->clk = devm_clk_get(drm->dev, "pxlclk");
> @@ -268,8 +267,7 @@ static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
> drm->mode_config.max_height = 1080;
> drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
> + arcpgu->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(arcpgu->regs))
> return PTR_ERR(arcpgu->regs);
>
> --
> 2.39.0